🪟 🐛 Fix duplicate createUser calls on signup #21454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephkmh
commented
Jan 16, 2023
airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx
Outdated
Show resolved
Hide resolved
josephkmh
commented
Jan 16, 2023
airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx
Outdated
Show resolved
Hide resolved
|
@tealjulia FYI |
yeomann
reviewed
Jan 16, 2023
airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the tag. Saw the Slack thread yesterday and thought this might be the culprit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
onAfterAuth()was being called multiple times. This in turn was causing multiple calls toweb_backend/users/createwith the same user information, which caused many 409s (conflicting user names) and spamming our oncall with failed requests.How
Reverts the change introduced in #21175
Considerations
The auth service is missing tests, which could help avoid this. The component is complex and depends on many other modules, so testing this is out of scope for this PR.