🪟 🔧 ☁️ Check email verification status for free connector enrollment

[ambirdsall]

What

A few improvements to the frontend for free connector enrollment:

• passes emailVerified and sendEmailVerification into EnrollmentModalContent as props (via useAuthService(), which can't be called within the modal content component itself but can be from the useShowEnrollmentModal hook)
• if and only if the user hasn't verified their email:
  • conditionally renders a new callout with a link to resend the email verification
  • disables the CTA
• minor refactors to the useFreeConnectorProgram hook
  • extracts the experiment flag check into the hook, making it a single source of truth to override or update
  • rename the function to match its filename

Screenshot of the modal for a user with unvalidated email:

Okay, but why is CreditsPage/components/EmailVerificationHint.tsx in this PR

Right, that. That component was the only place in the app that used the sendEmailVerification function from useAuthService. It also added a bunch of error handling that we'll want every time we use this API, so before I used sendEmailVerification in the FCP enrollment modal, I extracted the error handling into useAuthService itself, so we would get it "for free". As of now, the error handling strategy is hardcoded in the hook; if the need for context-dependent error handling arises, we will have to rewrite sendEmailVerification to return some well-typed error object instead of handling errors right inside the function. But I'm not sure we're gonna need it.

Recommended reading order

There are three pairs of files whose changes are linked; you can read them in either order, but should probably consider them together.

1. useShowEnrollmentModal.tsx / EnrollmentModal.tsx
2. useFreeConnectorProgram.ts / ConnectionPageTitle.tsx
3. EmailVerificationHint.tsx / AuthService.tsx
4. the rest

[github-actions]

[note from Alex] ignore this bot: it's talking about an unrelated file that got pulled in from latest master (and then rebased out again straightaway to keep the diff clean)

Airbyte Code Coverage

File	Coverage [45.16%]	❌
EnvConfigs.java	45.16%	❌

Total Project Coverage	26.63%	🍏

[teallarson]

Could use a rebase to remove changes from the inline banner.

Other than that, one comment and one question but looks pretty much good to go.

[ambirdsall]

these are not being deleted, just moved to the cloud-specific locale file

[teallarson]

Nice!

Some thoughts I had trying it out:

• Could use a success message on send ("verification email sent!" or something along the lines)
• I have to refresh the page after verifying to remove the warning

[ambirdsall]

@tealjulia there's a slack discussion on the confirmation feedback; definitely going to be added, though I might hold that for a follow-up for easier reviewing.

The other issue, "have to refresh the page after verifying to remove the warning", would have to be solved by polling AuthService outside of the modal and re-triggering it if the value changes. Definitely possible, but might be enough of a headache to accept the need to refresh (at least for the time being).

[teallarson]

The other issue, "have to refresh the page after verifying to remove the warning", would have to be solved by polling AuthService outside of the modal and re-triggering it if the value changes. Definitely possible, but might be enough of a headache to accept the need to refresh (at least for the time being).

Reasonable! I wouldn't say it's blocking. Possibly a related solution to https://github.com/airbytehq/airbyte-cloud/issues/3992 (redirecting when a user logs out or in in a separate tab)