Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 ✍🏼 Update catalog diff modal confirm label to 'OK' #21520

Merged
merged 1 commit into from
Jan 18, 2023
Merged

🪟 ✍🏼 Update catalog diff modal confirm label to 'OK' #21520

merged 1 commit into from
Jan 18, 2023

Conversation

edmundito
Copy link
Contributor

What

Updates the confirm button text in the catalog diff modal from "Confirm" to "OK".

@edmundito edmundito requested a review from dizel852 January 18, 2023 13:58
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 18, 2023
@edmundito edmundito mentioned this pull request Jan 18, 2023
Merged
@dizel852 dizel852 assigned dizel852 and unassigned dizel852 Jan 18, 2023
dizel852
dizel852 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested locally

@edmundito edmundito enabled auto-merge (squash) January 18, 2023 14:09
@edmundito edmundito merged commit c248377 into master Jan 18, 2023
@edmundito edmundito deleted the edmundito/update-diff-modal-confirm-text branch January 18, 2023 14:27
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizel852 dizel852 dizel852 approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundito @dizel852 @octavia-squidington-iv