-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Jira: Small fix in the board stream #21524
Source Jira: Small fix in the board stream #21524
Conversation
/test connector=connectors/source-jira
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I started the tests to check if it will work.
airbyte-integrations/connectors/source-jira/source_jira/streams.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget one suggestion
airbyte-integrations/connectors/source-jira/source_jira/streams.py
Outdated
Show resolved
Hide resolved
Thank you for the review! I applied the changes requested @marcosmarxm |
Bump. encountered this error too |
/test connector=connectors/source-jira
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* fix board stream * revert debug changes * one more fix * code improvements based on suggestion --------- Co-authored-by: Nataly Merezhuk <65251165+natalyjazzviolin@users.noreply.github.com>
* fix board stream * revert debug changes * one more fix * code improvements based on suggestion --------- Co-authored-by: Nataly Merezhuk <65251165+natalyjazzviolin@users.noreply.github.com>
Awesome fix. When can we expect a release? |
What
Some boards don't have projects associated with them. Thus, some records don't have the fields inside the location dict. I created a fail-safe approach.
How
Use get instead. The project fields will be None if no project is available.
Recommended reading order
🚨 User Impact 🚨
Boards stream won't break
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Passing
Integration
Passing
Acceptance
Passing