Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #19981] fix unexpected tag error #21543

Merged
merged 1 commit into from
Jan 18, 2023
Merged

[ISSUE #19981] fix unexpected tag error #21543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/publish-cdk-command-manually.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,14 @@ jobs:
new_version="$(grep -i 'current_version = ' .bumpversion.cfg | sed -e 's/.* = //')"
awk -v NEW_VERSION="$new_version" -v CHANGELOG_MESSAGE="${{ github.event.inputs.changelog-message }}" 'NR==3{print "## " NEW_VERSION "\n" CHANGELOG_MESSAGE "\n"}1' CHANGELOG.md > tmp && mv tmp CHANGELOG.md
- name: Commit and Push Changes
if: success()
maxi297 marked this conversation as resolved.
Show resolved Hide resolved
uses: stefanzweifel/git-auto-commit-action@v4
with:
file_pattern: airbyte-cdk/python/setup.py airbyte-cdk/python/.bumpversion.cfg airbyte-cdk/python/CHANGELOG.md
commit_message: 🤖 Bump ${{ github.event.inputs.release-type }} version of Airbyte CDK
commit_user_name: Octavia Squidington III
commit_user_email: octavia-squidington-iii@users.noreply.github.com
- name: Post failure to Slack channel dev-connectors-extensibility
if: !success()
if: ${{ failure() }}
uses: slackapi/slack-github-action@v1.23.0
continue-on-error: true
with:
Expand Down Expand Up @@ -107,7 +106,7 @@ jobs:
- name: Build CDK Package
run: SUB_BUILD=CONNECTORS_BASE ./gradlew --no-daemon --no-build-cache :airbyte-cdk:python:build
- name: Post failure to Slack channel dev-connectors-extensibility
if: !success()
if: ${{ failure() }}
uses: slackapi/slack-github-action@v1.23.0
continue-on-error: true
with:
Expand Down Expand Up @@ -167,7 +166,6 @@ jobs:
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
- name: Post success to Slack channel dev-connectors-extensibility
if: success()
maxi297 marked this conversation as resolved.
Show resolved Hide resolved
erohmensing marked this conversation as resolved.
Show resolved Hide resolved
uses: slackapi/slack-github-action@v1.23.0
continue-on-error: true
with:
Expand Down Expand Up @@ -195,7 +193,7 @@ jobs:
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN_AIRBYTE_TEAM }}
- name: Post failure to Slack channel dev-connectors-extensibility
if: !success()
if: ${{ failure() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if: failure() should work too

uses: slackapi/slack-github-action@v1.23.0
continue-on-error: true
with:
Expand Down