Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make destination-clickhouse-strict-encrypt use the correct class #21570

Merged
merged 8 commits into from
Jan 19, 2023
Merged

Make destination-clickhouse-strict-encrypt use the correct class #21570

merged 8 commits into from
Jan 19, 2023

Conversation

grishick
Copy link
Contributor

What

destination-clickhouse-strict-encrypt is using ClickhouseDestination as the mainClass in the build, which means that it is not removing SSL option from the UI. This change fixes build.gradle and bumps the version of destination-clickhouse-strict-encrypt.
This change also bumps the version of destination-clickhouse in order to keep it in sync with the strict encrypt version

@grishick grishick requested a review from a team as a code owner January 19, 2023 00:24
@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3954132829
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3954132829
🐛

ryankfu
ryankfu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending publishing connector

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023 •
edited
Loading

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (2)
Connector Version Changelog Publish
destination-clickhouse 0.2.2 ❌
(changelog missing)		 ✅
destination-clickhouse-strict-encrypt 0.2.2 🔵
(ignored)		 🔵
(ignored)
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)
  • base-normalization

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3954164666
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3954164666
🐛

@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse

🕑 Publishing the following connectors:
connectors/destination-clickhouse
https://github.com/airbytehq/airbyte/actions/runs/3954176473


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse

🕑 Publishing the following connectors:
connectors/destination-clickhouse
https://github.com/airbytehq/airbyte/actions/runs/3954223943


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick temporarily deployed to more-secrets January 19, 2023 00:43 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 19, 2023 00:43 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse

🕑 Publishing the following connectors:
connectors/destination-clickhouse
https://github.com/airbytehq/airbyte/actions/runs/3954286266


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.77% 🍏

@grishick grishick temporarily deployed to more-secrets January 19, 2023 00:54 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 19, 2023 00:54 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse run-tests=false

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick force-pushed the greg/fix-clickhouse-strict-encrypt branch from 20fa8d3 to 7cc0593 Compare January 19, 2023 16:18
@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse run-tests=false

🕑 Publishing the following connectors:
connectors/destination-clickhouse
https://github.com/airbytehq/airbyte/actions/runs/3960369853


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 19, 2023
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2023 16:52 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

grishick commented Jan 19, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-clickhouse-strict-encrypt run-tests=false

🕑 Publishing the following connectors:
connectors/destination-clickhouse-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3960776699


Connector Did it publish? Were definitions generated?
connectors/destination-clickhouse-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick force-pushed the greg/fix-clickhouse-strict-encrypt branch from c805801 to e35bee6 Compare January 19, 2023 17:35
@grishick grishick enabled auto-merge (squash) January 19, 2023 17:40
@grishick grishick temporarily deployed to more-secrets January 19, 2023 17:43 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 19, 2023 17:45 — with GitHub Actions Inactive
@grishick grishick merged commit 9c3219b into master Jan 19, 2023
@grishick grishick deleted the greg/fix-clickhouse-strict-encrypt branch January 19, 2023 18:45
etsybaev pushed a commit that referenced this pull request Jan 19, 2023
@grishick @etsybaev
Make destination-clickhouse-strict-encrypt use the correct class (#21570
ad8814b 
)

* Use ClickhouseDestinationStrictEncrypt in strict-encrypt clickhouse destination
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grishick @ryankfu @octavia-squidington-iii @octavia-squidington-iv