Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector daily integration tests: new job for alpha connectors #21591

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 19, 2023

What

Declare a separate job to run alpha connectors build only in the daily Connector Integration Tests run.
I reverted #21589 because all the builds can't run in 30mn.
For orchestration and timeout reasons I prefer to declare it in a second job.

@alafanechere alafanechere force-pushed the augustin/alpha-daily-integration-tests branch from 08b4189 to f7cf6b7 Compare January 19, 2023 12:29
@alafanechere alafanechere changed the title new workflow Connector daily integration tests: new job for alpha connectors Jan 19, 2023
@alafanechere alafanechere marked this pull request as ready for review January 19, 2023 12:30
@alafanechere alafanechere requested review from a team and removed request for a team January 19, 2023 12:30
@alafanechere alafanechere temporarily deployed to more-secrets January 19, 2023 12:31 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 19, 2023 12:31 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.77% 🍏

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like having them as 2 separate jobs, in case we end up wanting to point them to different places. Wondering what led us to pick 30 minutes as a timeout for the initial job, and should we have some sort of timeout for this one, even if a longer one?

@@ -29,3 +29,22 @@ jobs:
run: python ./tools/bin/ci_integration_workflow_launcher.py base-normalization source-acceptance-test source:alpha source:beta source:GA destination:alpha destination:beta destination:GA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the alpha connectors are still in here, maybe you need to merge master in to this branch? Just to validate

@alafanechere alafanechere temporarily deployed to more-secrets January 19, 2023 15:28 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 19, 2023 15:29 — with GitHub Actions Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 19, 2023

Wondering what led us to pick 30 minutes as a timeout for the initial job.

I don't know exactly but I think it's to have a kind of guarantee that all the test run in 30mn to build the report that is sent on slack afterward in a different action.

And should we have some sort of timeout for this one, even if a longer one?

I hope the default 360mn is good enough.
The scripts of this workflow triggers /test workflow in parallel, I hope that we can build all our alpha connectors in parallel in less than 6hours...
I'll figure out tomorrow 😄

@alafanechere alafanechere merged commit 8a96a7c into master Jan 19, 2023
@alafanechere alafanechere deleted the augustin/alpha-daily-integration-tests branch January 19, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants