-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector daily integration tests: new job for alpha connectors #21591
Conversation
08b4189
to
f7cf6b7
Compare
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like having them as 2 separate jobs, in case we end up wanting to point them to different places. Wondering what led us to pick 30 minutes as a timeout for the initial job, and should we have some sort of timeout for this one, even if a longer one?
@@ -29,3 +29,22 @@ jobs: | |||
run: python ./tools/bin/ci_integration_workflow_launcher.py base-normalization source-acceptance-test source:alpha source:beta source:GA destination:alpha destination:beta destination:GA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the alpha connectors are still in here, maybe you need to merge master in to this branch? Just to validate
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
I don't know exactly but I think it's to have a kind of guarantee that all the test run in 30mn to build the report that is sent on slack afterward in a different action.
I hope the default 360mn is good enough. |
What
Declare a separate job to run
alpha
connectors build only in the daily Connector Integration Tests run.I reverted #21589 because all the builds can't run in 30mn.
For orchestration and timeout reasons I prefer to declare it in a second job.