Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source and destination definition calls that were used only to get the icon in Streams Field Table #21608

Conversation

krishnaglick
Copy link
Contributor

@krishnaglick krishnaglick commented Jan 19, 2023

Resolves #21622

What

Remove source and destination definition calls that were used only to get the icon.

How

Reference the icon on the Source and Destination directly instead of their definition

Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested locally - no issues 👍

@krishnaglick krishnaglick merged commit 95f2c45 into master Jan 19, 2023
@krishnaglick krishnaglick deleted the kc/remove-excess-source-and-destination-definition-calls-in-streams-field-table branch January 19, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove source and destination definition calls from Streams Field Table
2 participants