Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Talk: enable high test strictness level in SAT #21618

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airbyte-integrations/connectors/source-zendesk-talk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ and place them into `secrets/config.json`.
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog sample_files/configured_catalog.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/zendesk-talk:dev
docker build . -t airbyte/source-zendesk-talk:dev
```

You can also build the connector image via Gradle:
Expand All @@ -79,7 +79,7 @@ docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
pip install .'[tests]'
```
### Unit Tests
To run unit tests locally, from the connector directory run:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,52 @@
# for more information about how to configure these tests
# intentionally left out explicit configured_catalog.json to test all streams from discovery
connector_image: airbyte/source-zendesk-talk:dev
tests:
test_strictness_level: "high"
acceptance_tests:
spec:
- spec_path: "source_zendesk_talk/spec.json"
tests:
- spec_path: "source_zendesk_talk/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
- config_path: "secrets/config_old.json"
status: "succeed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
- config_path: "secrets/config_old.json"
status: "succeed"
discovery:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.3"
- config_path: "secrets/config_old.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.3"
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.3"
- config_path: "secrets/config_old.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.3"
basic_read:
- config_path: "secrets/config.json"
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
extra_fields: no
exact_order: no
extra_records: yes
empty_streams:
- name: "account_overview"
bypass_reason: "The objects can mutate quite often."
- name: "agents_overview"
bypass_reason: "The objects can mutate quite often."
- name: "current_queue_activity"
bypass_reason: "The objects can mutate quite often."
lazebnyi marked this conversation as resolved.
Show resolved Hide resolved
incremental:
- config_path: "secrets/config.json"
future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: "secrets/config.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
account_overview: ["current_timestamp"]
agents_overview: ["current_timestamp"]
current_queue_activity: ["current_timestamp"]
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
account_overview: ["current_timestamp"]
agents_overview: ["current_timestamp"]
current_queue_activity: ["current_timestamp"]
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
{
"calls": {
"updated_at": "2121-01-01T00:00:00Z"
[
{
"type": "STREAM",
"stream": {
"stream_state": {
"updated_at": "2121-01-01T00:00:00Z"
},
"stream_descriptor": { "name": "calls" }
}
},
"call_legs": {
"updated_at": "2121-01-01T00:00:00Z"
{
"type": "STREAM",
"stream": {
"stream_state": {
"updated_at": "2121-01-01T00:00:00Z"
},
"stream_descriptor": { "name": "call_legs" }
}
}
}
]
Loading