Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟🐛 Connector builder UI: Fix inputs modal #21643

Merged
merged 3 commits into from
Jan 24, 2023
Merged

🪟🐛 Connector builder UI: Fix inputs modal #21643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84170f0
fix
Jan 20, 2023
b240e7c
fix
Jan 20, 2023
4c2f1eb
Merge branch 'master' into flash1293/inputs-modal-fixes2
lmossman Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ const InnerBuilderField: React.FC<BuilderFieldProps & FastFieldProps<unknown>> =

export const BuilderField: React.FC<BuilderFieldProps> = (props) => {
return (
<FastField name={props.path}>
// The key is set to enforce a re-render of the component if the type change, otherwise changes in props might not be reflected correctly
<FastField name={props.path} key={props.type}>
{({ field, form, meta }: FastFieldProps<unknown>) => (
<InnerBuilderField {...props} field={field} form={form} meta={meta} />
)}
Expand Down
7 changes: 0 additions & 7 deletions airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,6 @@ const InputModal = ({
label={formatMessage({ id: "connectorBuilder.inputModal.default" })}
/>
)}
<BuilderField
path="definition.placeholder"
type="string"
optional
label={formatMessage({ id: "connectorBuilder.inputModal.placeholder" })}
tooltip={formatMessage({ id: "connectorBuilder.inputModal.placeholderTooltip" })}
/>
</>
) : (
<Callout className={styles.calloutContainer}>
Expand Down