Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add No content status code #21655

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Add No content status code #21655

merged 4 commits into from
Jan 23, 2023

Conversation

benmoriceau
Copy link
Contributor

What

Some method we returning 204 with jaxRs but 200 with Micronaut, this is fixing it.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Jan 20, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 15:51 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 15:51 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 17:12 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 17:12 — with GitHub Actions Inactive
@benmoriceau benmoriceau enabled auto-merge (squash) January 20, 2023 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [0%] ❌
WorkspaceApiController.java 0% ❌
SourceDefinitionApiController.java 0% ❌
DestinationDefinitionApiController.java 0% ❌
DestinationApiController.java 0% ❌
SourceApiController.java 0% ❌
OperationApiController.java 0% ❌
ConnectionApiController.java 0% ❌
Total Project Coverage 26.75% 🍏

@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 21:08 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 21:08 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 22:19 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 22:19 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 23, 2023 17:55 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 23, 2023 17:56 — with GitHub Actions Inactive
@benmoriceau benmoriceau merged commit b7d5be9 into master Jan 23, 2023
@benmoriceau benmoriceau deleted the bmoric/fix-delete branch January 23, 2023 18:32
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@gosusnp gosusnp Awaiting requested review from gosusnp

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmoriceau @jdpgrailsdev @octavia-squidington-iv