Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector Builder] Add Segment event tracking #21686

Merged
merged 24 commits into from
Jan 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4d3e1e6
direct connector builder to first workspace and fix routing
lmossman Jan 20, 2023
a65a5c7
add connector builder namespace and actions
lmossman Jan 20, 2023
2164dcf
track connector builder start event
lmossman Jan 20, 2023
516ade8
track api url created event
lmossman Jan 20, 2023
7dbe844
track auth method select
lmossman Jan 20, 2023
f4e07ca
fix action description
lmossman Jan 20, 2023
6d328d9
track user input events
lmossman Jan 20, 2023
d547921
track sidebar events
lmossman Jan 20, 2023
802a0ef
track stream creation
lmossman Jan 20, 2023
97b6cc3
track copying stream
lmossman Jan 20, 2023
f7fc2a8
track stream delete
lmossman Jan 20, 2023
fd36241
track stream test success/failure
lmossman Jan 21, 2023
3f54306
track download yaml and fix yaml file name
lmossman Jan 21, 2023
dc26c64
track events for switching between ui/yaml
lmossman Jan 21, 2023
45ed276
track events for overwriting and merging schemas
lmossman Jan 21, 2023
09967f0
fix stream test failure/success events and add tracking of test initi…
lmossman Jan 24, 2023
b0cb1a6
do not send schema contents in events
lmossman Jan 24, 2023
2422440
Merge branch 'master' into lmossman/connector-builder-event-tracking
lmossman Jan 25, 2023
2d309ec
track when stream is selected from testing panel
lmossman Jan 25, 2023
7451ad4
fix typo
lmossman Jan 25, 2023
6791083
handle initial setup completed in e2e tests
lmossman Jan 25, 2023
f9a8a0d
add warning about not putting sensitive info into URL fields
lmossman Jan 25, 2023
b72e40e
fix before in e2e test
lmossman Jan 25, 2023
c9dc3e7
Merge branch 'master' into lmossman/connector-builder-event-tracking
lmossman Jan 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
direct connector builder to first workspace and fix routing
lmossman committed Jan 20, 2023
commit 4d3e1e650d92b9b9f4642adc31ce2b969134539d
10 changes: 7 additions & 3 deletions airbyte-webapp/src/pages/routes.tsx
Original file line number Diff line number Diff line change
@@ -85,12 +85,12 @@ export const AutoSelectFirstWorkspace: React.FC<{ includePath?: boolean }> = ({
);
};

const RoutingWithWorkspace: React.FC = () => {
const RoutingWithWorkspace: React.FC<{ element?: JSX.Element }> = ({ element }) => {
const workspace = useCurrentWorkspace();
useAddAnalyticsContextForWorkspace(workspace);
useApiHealthPoll();

return workspace.initialSetupComplete ? <MainViewRoutes /> : <PreferencesRoutes />;
return workspace.initialSetupComplete ? element ?? <MainViewRoutes /> : <PreferencesRoutes />;
};

export const Routing: React.FC = () => {
@@ -110,7 +110,11 @@ export const Routing: React.FC = () => {
);
return (
<Routes>
<Route path={`${RoutePaths.ConnectorBuilder}/*`} element={<ConnectorBuilderPage />} />
<Route
path={`${RoutePaths.Workspaces}/:workspaceId/${RoutePaths.ConnectorBuilder}`}
element={<RoutingWithWorkspace element={<ConnectorBuilderPage />} />}
/>
<Route path={`${RoutePaths.ConnectorBuilder}/*`} element={<AutoSelectFirstWorkspace includePath />} />
{OldRoutes}
<Route path={RoutePaths.AuthFlow} element={<CompleteOauthRequest />} />
<Route path={`${RoutePaths.Workspaces}/:workspaceId/*`} element={<RoutingWithWorkspace />} />