Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low Code CDK] surface the resolved manifest in the CDK #21703

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jan 23, 2023

This is the CDK update portion of #21565; the CDK update needs to be published before the connector builder server CI will pass.

This will be used by the connector builder server.
@clnoll clnoll requested a review from a team as a code owner January 23, 2023 13:49
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Jan 23, 2023
@clnoll clnoll requested a review from maxi297 January 23, 2023 13:50
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And out of curiosity, why not update the connector builder server in the same PR?

@clnoll
Copy link
Contributor Author

clnoll commented Jan 23, 2023

@maxi297 the connector builder server CI tests run against the latest published version of the CDK. Since the CB changes rely on changes to the CDK, CB tests will fail until the new version of the CDK is published. To make CDK & CB changes in one PR, I'd have to publish the CDK off of the same branch that CB changes are in, then rerun the CI tests once publishing is done, and then merge the code. Since the new workflow is 1) merge to master, then 2) publish the new CDK version, I don't think that will plan will work anymore. Even if it does still work, it would mean publishing the CDK despite getting a red build. Although the test failures are due to the CB and not the CDK, that still makes me a bit uncomfortable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants