Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic manifest.yaml name for manifest in generated lowcode CDK connectors #21770

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Jan 24, 2023

Making the name uniform because it allows us to simplify any automation on top of lowcode connectors and workflows like downloading a user's YAML for debugging or running a connector builder connector on the UI.

Might merge another PR batch applying this rename to connectors

@maxi297
Copy link
Contributor

maxi297 commented Jan 24, 2023

Might merge another PR batch applying this rename to connectors

This could be interesting. I see that we are building automation around this (first thing that comes up to my head is migrating manifests but there might be more) and migrating the manifest will impact those. What is the timing/the urgency associated to this compared to low code CDK to beta?

@sherifnada
Copy link
Contributor Author

sherifnada commented Jan 24, 2023

@maxi297 does this impact the migration to beta? I would have guessed it's not a big blocker/disruption. See #21771. In any case, happy to hold off on that PR

This PR only impacts new connectors

@maxi297
Copy link
Contributor

maxi297 commented Jan 25, 2023

does this impact the migration to beta?

@sherifnada Yes it does but don't hold for us. As you mentioned, not a big blocked. Just something we need to take into account so that we update our migration scripts. You can go forward with the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants