qa-engine: implement fetch_adoption_metrics_per_connector_version
#21840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
force-pushed
the
augustin/qa-engine/fetch-connector-adoption-metrics
branch
from
158459e to
f3dccef
Compare
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
commented
Jan 25, 2023
|
|
||
| setup( | ||
| version="0.1.3", | ||
| version="0.1.5", |
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
|
I'm requesting a review from @airbytehq/airbyte-analytics to check my SQL query looks good 😄 |
Airbyte Code Coverage
|
evantahler
approved these changes
Jan 25, 2023
tools/ci_connector_ops/ci_connector_ops/qa_engine/connector_adoption.sql
Show resolved
Hide resolved
zzztimbo
approved these changes
Jan 25, 2023
tools/ci_connector_ops/ci_connector_ops/qa_engine/connector_adoption.sql
Outdated
Show resolved
Hide resolved
tools/ci_connector_ops/ci_connector_ops/qa_engine/connector_adoption.sql
Outdated
Show resolved
Hide resolved
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
deleted the
augustin/qa-engine/fetch-connector-adoption-metrics
branch
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
1/2 to complete #21721
Implement the logic to retrieve adoption metrics per connector version from our data warehouse.
The
fetch_adoption_metrics_per_connector_versionis not actually called, waiting for #21776 to use it.How
https://github.com/airbytehq/airbyte/blob/158459e3ee80847cbdcee3bd78557a43e274f07c/tools/ci_connector_ops/ci_connector_ops/qa_engine/connector_adoption.sql#L1
https://github.com/airbytehq/airbyte/blob/158459e3ee80847cbdcee3bd78557a43e274f07c/tools/ci_connector_ops/ci_connector_ops/qa_engine/inputs.py#L44
https://github.com/airbytehq/airbyte/blob/158459e3ee80847cbdcee3bd78557a43e274f07c/.github/workflows/run-qa-engine.yml#L31
fetch_adoption_metrics_per_connector_versionfunction:https://github.com/airbytehq/airbyte/blob/158459e3ee80847cbdcee3bd78557a43e274f07c/tools/ci_connector_ops/tests/test_qa_engine/test_inputs.py#L20