Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Remove z-index rule from Switch component handle #21857

Merged
merged 1 commit into from
Jan 25, 2023
Merged

🪟 🎨 Remove z-index rule from Switch component handle #21857

merged 1 commit into from
Jan 25, 2023

Conversation

edmundito
Copy link
Contributor

What

Removes the z-index from the Switch handle CSS rule. This is an old rule that may no longer be needed. Tested and could not find any situations where the Switch was rendering incorrectly.

@edmundito edmundito requested a review from a team January 25, 2023 16:25
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 25, 2023
teallarson
teallarson approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 checked behavior manually on connections list table, connection item page (title and table), behind a modal, behind an overlay, and in stream details panel that interactivity and animation are as expected.

This seems like a safe change to make.

dizel852
dizel852 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally - have not found any issues

@edmundito edmundito force-pushed the edmundito/remove-switch-z-index branch from 60fdda5 to c10d157 Compare January 25, 2023 18:43
@edmundito edmundito enabled auto-merge (squash) January 25, 2023 18:43
@edmundito edmundito merged commit 0e3d2ba into master Jan 25, 2023
@edmundito edmundito deleted the edmundito/remove-switch-z-index branch January 25, 2023 19:07
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

@dizel852 dizel852 dizel852 approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundito @dizel852 @teallarson @octavia-squidington-iv