Bmoric/controller utest #21882
Merged
Bmoric/controller utest #21882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
requested review from
alovew,
colesnodgrass,
gosusnp and
jdpgrailsdev
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
commented
Jan 30, 2023
|
|
||
| @Test | ||
| void testHealth() throws IOException { | ||
| Mockito.when(healthCheckHandler.health()) |
There was a problem hiding this comment.
The lack of this mocking is the reason why we were runnign in a NotFound error. It was not because the route was not register but because the response was null which lead micronaut to return a notFound error.
Airbyte Code Coverage
|
* Add attempt and connection test * Add more test * Add more test * pmd
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
gosusnp
approved these changes
Feb 15, 2023
| defaultValue = StringUtils.TRUE, | ||
| value = StringUtils.TRUE) | ||
| @SuppressWarnings("PMD.AbstractClassWithoutAbstractMethod") | ||
| abstract class BaseControllerTest { |
There was a problem hiding this comment.
It could be useful to add some comments about the intent of the tests (testing the error wrapping of the controllers mostly?). It feels very redundant to add that to every single test class, the base class might be a good place for this.
|
Tagged as ready to ship since it is only UTests |
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
|
/create-platform-pr |
perangel
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
perangel
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
|
/create-platform-pr |
|
/create-platform-pr |
benmoriceau
added a commit
that referenced
this pull request
Mar 2, 2023
This reverts commit da17885.
benmoriceau
added a commit
that referenced
this pull request
Mar 2, 2023
benmoriceau
added a commit
that referenced
this pull request
Mar 2, 2023
jbfbell
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Tmp * Tmp * Tmp * tmp * Make test to work * PMD and update test * Bmoric/add more controller tests (#22113) * Add attempt and connection test * Add more test * Add more test * pmd * Rm unused import * Add comment * More test and address comments * PR comments
jbfbell
pushed a commit
that referenced
this pull request
Mar 6, 2023
danielduckworth
pushed a commit
to danielduckworth/airbyte
that referenced
this pull request
Mar 13, 2023
* Tmp * Tmp * Tmp * tmp * Make test to work * PMD and update test * Bmoric/add more controller tests (airbytehq#22113) * Add attempt and connection test * Add more test * Add more test * pmd * Rm unused import * Add comment * More test and address comments * PR comments
danielduckworth
pushed a commit
to danielduckworth/airbyte
that referenced
this pull request
Mar 13, 2023
This reverts commit da17885.
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a UTest to check the return code of our API endpoints.
How
Create a UTEST (actually, it is more an integration test) that checks that the endpoint we're call returns the expected code. This PR only contains the HealthCheck. Other PR(s) will add the other endpoints.