Fixed mismatch spec variable and updates default value #21890

ryankfu · 2023-01-25T22:18:25Z

What

Addresses a spec and variable mismatch addressed in this comment. It prevented users from being able to configure the number of file buffers. It also fixes the spec.json to properly reflect the default value for file buffers

How

Describe the solution

🚨 User Impact 🚨

No user impact, will resolve issue with bug on configurable property

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

ryankfu · 2023-01-25T22:19:12Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/4010440244
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/4010440244
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

github-actions · 2023-01-25T22:20:39Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (1)

Connector	Version	Changelog	Publish
`destination-redshift`	`0.3.56`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

adam-bloom · 2023-01-26T19:16:25Z

Thanks @ryankfu! I'll follow here to see when it is published, but can build this branch locally in the meantime.

ryankfu · 2023-01-27T18:27:49Z

/publish connector=connectors/destination-redshift

🕑 Publishing the following connectors:
connectors/destination-redshift
https://github.com/airbytehq/airbyte/actions/runs/4027179010

Connector	Did it publish?	Were definitions generated?
connectors/destination-redshift	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-01-27T19:31:44Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24%	❌

ryankfu requested a review from a team as a code owner January 25, 2023 22:18

octavia-squidington-iv added connectors/destination/redshift area/connectors Connector related issues labels Jan 25, 2023

grishick approved these changes Jan 25, 2023

View reviewed changes

ryankfu mentioned this pull request Jan 26, 2023

Destination BigQuery: configurable value for file buffer #20975

Closed

2 tasks

ryankfu added 3 commits January 26, 2023 14:53

Fixed mismatch spec variable and updates default value

38fdf37

Updates spec default values

28b2c69

Bumps connector version and documentation

c9fa765

ryankfu force-pushed the ryan/fix-spec-mismatch-filebuffer-redshift branch from b4b8040 to c9fa765 Compare January 26, 2023 23:09

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 26, 2023

auto-bump connector version

bc4c907

octavia-squidington-iii temporarily deployed to more-secrets January 27, 2023 19:22 — with GitHub Actions Inactive

ryankfu merged commit c0d3900 into master Jan 27, 2023

ryankfu deleted the ryan/fix-spec-mismatch-filebuffer-redshift branch January 27, 2023 19:59

octavia-squidington-iii mentioned this pull request Jan 27, 2023

Bump Airbyte version from 0.40.29 to 0.40.30 #22045

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed mismatch spec variable and updates default value #21890

Fixed mismatch spec variable and updates default value #21890

ryankfu commented Jan 25, 2023

ryankfu commented Jan 25, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 25, 2023 •

edited

Loading

✅ Sources (0)

✅ Destinations (1)

👀 Other Modules (1)

Actionable Items

adam-bloom commented Jan 26, 2023

ryankfu commented Jan 27, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 27, 2023

Fixed mismatch spec variable and updates default value #21890

Fixed mismatch spec variable and updates default value #21890

Conversation

ryankfu commented Jan 25, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

ryankfu commented Jan 25, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Jan 25, 2023 • edited Loading

Affected Connector Report

✅ Sources (0)

✅ Destinations (1)

👀 Other Modules (1)

Actionable Items

adam-bloom commented Jan 26, 2023

ryankfu commented Jan 27, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 27, 2023

Airbyte Code Coverage

ryankfu commented Jan 25, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 25, 2023 •

edited

Loading

ryankfu commented Jan 27, 2023 •

edited by github-actions bot

Loading