-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🐛 Fixes BulkEditServiceProvider to use filtered streams instead of all streams #21902
🪟 🐛 Fixes BulkEditServiceProvider to use filtered streams instead of all streams #21902
Conversation
Found a bug while testing:
You will notice that there is only the streams that were filtered, but the others are gone! |
Hmm... Interesting use-case. Probably we need to unselect all selected streams when the user changes filter settings. |
Confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as expected. Tested:
- Editing streams before and after bulk edit
- Cancel and Save
- Editing filtered streams with bulk edit
I just read the question about changing the search during bulk editing. I think the best option is to disable the search input while bulk edit is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with disabled search, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Closes #21551
How
The solution is pretty straightforward, I just used filtered streams to use inside
<BulkEditServiceProvider />
https://www.loom.com/share/b02731e1759948e1b299a6ed9836ea3c
But there is a tricky moment here. What should we do in case we checked all streams with some keywords and got for example 50 streams selected, but after that, we typed more symbols to search string and got only 10 results? In this case, those 50 streams will be still selected inside
useBulkEditService
while only 10 will be visible to the userhttps://www.loom.com/share/466809e75bb74157915b91a6494560b0
As you can see right now
selectedBatchNodeIds
andselectedBatchNodes
are not the same in the current implementation. So what should we do with this?