-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low-Code CDK: make DatetimeStreamSlicer.step InterpolatedString #21930
Low-Code CDK: make DatetimeStreamSlicer.step InterpolatedString #21930
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
airbyte-cdk/python/CHANGELOG.md
Outdated
@@ -1,5 +1,8 @@ | |||
# Changelog | |||
|
|||
## 0.25.1 | |||
Low-Code CDK: make DatetimeStreamSlicer.step as InterpolatedString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the new release process, the version is updated in the new GitHub workflow. You can check https://airbytehq-team.slack.com/archives/C02UF50V9HA/p1674655636577679?thread_ts=1674654710.391809&cid=C02UF50V9HA for more information.
An example of the issue is this: you have another PR at the same time that has the same release version. This will clash i.e. one of the release will fail. To avoid this, we should always release on master. This allows to have one source of truth for the version and not multiple (one per branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issue with this MR. However, I'm curious in what cases this could be useful. Can you provide an example?
Hello, tag: @maxi297 |
Thanks a lot for the example @grubberr ! The more I know, the better I feel haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a comment to approve. Good job!
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
__post__init
, it allows to interpolate only{{ config }}
, but one the other hand we fail fast if provided value is not correct