🪟 🔧 Prevent @use renaming in SASS #21931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephkmh
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Tested locally, looks good! 🥇
One thing I noticed while testing, which is rather related to vite (I think) than stylelint: after fixing a stylelint error, it seems like you have to restart vite to get stylelint to run again. tsc and eslint seem to re-check upon saving, but stylelint does not.
|
@josephkmh Thanks for pointing this out. I'll have a look at that next week. |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevents renaming of
@usestatements in SASS as discussed in our chapter sync.Also removes all the currently existing renames in SASS files.