Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attempt created to used codepath #21955

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

cgardens
Copy link
Contributor

Looks like I added the call to emit an attempt_created event in the wrong spot. I think it was a dead code path. Added to the real code path. Scheduled message in dev-platform-move to follow up on whether the dead code path can be removed.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 27, 2023
@cgardens cgardens temporarily deployed to more-secrets January 27, 2023 02:12 — with GitHub Actions Inactive
@cgardens cgardens temporarily deployed to more-secrets January 27, 2023 02:12 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

File Coverage [83.74%] 🍏
JobCreationAndStatusUpdateActivityImpl.java 83.74% 🍏
Total Project Coverage 24%

@cgardens cgardens merged commit 3676a97 into master Jan 27, 2023
@cgardens cgardens deleted the cgardens/attempt-created-fix branch January 27, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants