qa-engine: define cloud eligibility #21961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
force-pushed
the
augustin/qa-engine/define-eligibility
branch
from
bd2b382 to
022c054
Compare
alafanechere
commented
Jan 27, 2023
tools/ci_connector_ops/setup.py
Outdated
| @@ -23,7 +23,7 @@ | |||
|
|
|||
|
|
|||
| setup( | |||
| version="0.1.6", | |||
| version="0.1.8", | |||
There was a problem hiding this comment.
Anticipating the bump of #21917
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
erohmensing
approved these changes
Jan 27, 2023
tools/ci_connector_ops/ci_connector_ops/qa_engine/validations.py
Outdated
Show resolved
Hide resolved
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
…rbytehq/airbyte into augustin/qa-engine/define-eligibility
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #21919
How
is_eligible_for_cloudcolumn to the QA report dataframereport_generation_datetimecolumn to the QA report dataframe: might be useful in the future when we'll archive the QA reportsis_eligible_for_cloudfunction that checks the truthiness of the following conditions:get_connectors_eligible_for_cloudfunction which returns a generator of eligible connectors for cloud.