Remove unused methods #21988
Merged
Remove unused methods #21988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
requested review from
colesnodgrass,
jdpgrailsdev,
gosusnp,
cgardens and
alovew
octavia-squidington-iv
added
area/platform
benmoriceau
commented
Jan 27, 2023
| @@ -196,42 +192,6 @@ void createResetJob() throws JsonValidationException, ConfigNotFoundException, I | |||
| Assertions.assertThat(output.getJobId()).isEqualTo(JOB_ID); | |||
| } | |||
|
|
|||
| @Test | |||
| @DisplayName("Test attempt creation") | |||
| void createAttempt() throws IOException { | |||
There was a problem hiding this comment.
This test can be removed because there is already one that call the other method.
colesnodgrass
approved these changes
Jan 27, 2023
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
benmoriceau
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
cgardens
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove unused methods that we using a variable name attemptId which was actually an attemptNumber.