Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off default httpavailabilitystrategy for source-iterable (GA) #22011

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Jan 27, 2023

See #21888 for description

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable labels Jan 27, 2023
@erohmensing erohmensing changed the title Turn off default for source-iterable (GA) Turn off default httpavailabilitystrategy for source-iterable (GA) Jan 27, 2023
@erohmensing erohmensing requested a review from a team January 27, 2023 21:50
@erohmensing
Copy link
Contributor Author

erohmensing commented Jan 27, 2023

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4028599066
❌ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4028599066
🐛 https://gradle.com/s/4bd4f7yixbd2i

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream[email_send]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_send-10-200]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_send-100-200000]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_send-10000-200000]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_click-1000-20]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_open-1000-1]
	 FAILED unit_tests/test_export_adjustable_range.py::test_email_stream_chunked_encoding[email_open-1-1000]
	 �[31m================= �[31m�[1m7 failed�[0m, �[32m45 passed�[0m, �[33m1054 warnings�[0m�[31m in 1.80s�[0m�[31m ==================�[0m

@erohmensing
Copy link
Contributor Author

Same errors as in #connector-health

@erohmensing
Copy link
Contributor Author

erohmensing commented Jan 30, 2023

/publish connector=connectors/source-iterable run-tests=false

🕑 Publishing the following connectors:
connectors/source-iterable
https://github.com/airbytehq/airbyte/actions/runs/4045268671


Connector Did it publish? Were definitions generated?
connectors/source-iterable

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@erohmensing
Copy link
Contributor Author

Looking like run-tests=false is still running unit tests, which is why this one still fails 🤔

@erohmensing
Copy link
Contributor Author

erohmensing commented Feb 1, 2023

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4065638736
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4065638736
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_iterable/utils.py                  5      0   100%
source_iterable/__init__.py               2      0   100%
source_iterable/source.py                34      1    97%
source_iterable/slice_generators.py      71      5    93%
source_iterable/streams.py              356     38    89%
---------------------------------------------------------
TOTAL                                   468     44    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=========== 35 passed, 2 skipped, 37 warnings in 1333.04s (0:22:13) ============

@erohmensing
Copy link
Contributor Author

Tests were fixed here 🙌 #22202

@erohmensing
Copy link
Contributor Author

erohmensing commented Feb 1, 2023

/publish connector=connectors/source-iterable

🕑 Publishing the following connectors:
connectors/source-iterable
https://github.com/airbytehq/airbyte/actions/runs/4066106162


Connector Did it publish? Were definitions generated?
connectors/source-iterable

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2023 16:31 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2023 16:31 — with GitHub Actions Inactive
@erohmensing erohmensing enabled auto-merge (squash) February 1, 2023 16:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.62%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants