Turn off default httpavailabilitystrategy for source-marketo (GA) #22015

erohmensing · 2023-01-27T20:39:02Z

See #21888 for description

erohmensing · 2023-01-27T22:24:42Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4028652092
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4028652092
🐛 https://gradle.com/s/rwuxmyodblnng

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream progr...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
====== 1 failed, 28 passed, 2 skipped, 31 warnings in 2274.47s (0:37:54) =======

> Task :airbyte-integrations:connectors:source-marketo:sourceAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
48 actionable tasks: 23 executed, 25 up-to-date

Publishing build scan...
https://gradle.com/s/rwuxmyodblnng

The remote build cache was disabled during the build due to errors.
S3 cache writes: 1, elapsed: 701ms, sent to cache: 446 B

erohmensing · 2023-01-28T02:54:58Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4029848981
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4029848981
🐛 https://gradle.com/s/7l3ydtm4c3pcw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream progr...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
====== 1 failed, 28 passed, 2 skipped, 31 warnings in 2273.91s (0:37:53) =======

> Task :airbyte-integrations:connectors:source-marketo:sourceAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
48 actionable tasks: 23 executed, 25 up-to-date

Publishing build scan...
https://gradle.com/s/7l3ydtm4c3pcw

The remote build cache was disabled during the build due to errors.
S3 cache writes: 1, elapsed: 728ms, sent to cache: 448 B

erohmensing · 2023-01-28T06:12:27Z

Same failure as in #connector-health

evantahler · 2023-01-28T17:16:36Z

Then I think it's probably OK to merge

erohmensing · 2023-01-30T14:59:47Z

Thanks, will do. Double-checking all others for which this is the case and posting those as well!

erohmensing · 2023-01-30T15:04:52Z

/publish connector=connectors/source-marketo run-tests=false

🕑 Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4045182674

Connector	Did it publish?	Were definitions generated?
connectors/source-marketo	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

erohmensing · 2023-01-30T15:12:44Z

Apparently this version was published 11 days ago without a changelog, coming back to look into it

erohmensing · 2023-01-30T15:42:02Z

It was released off of this PR that was never merged: #20973. Seems to have been published by a contributor while skipping the tests

erohmensing · 2023-01-30T21:10:57Z

If I try to push a new version of the connector, I'd essentially be undoing the changes from the unmerged contributor PR for the latest version of the connector published. That would affect OSS users who upgraded to this version because they were seeing the issue linked in that PR.

However, cloud is still seeing 0.1.11, since the cloud catalog was never updated, since the PR was merged. Therefore cloud users should see no effects of going from 0.1.11 to 0.1.13. Users who want 0.1.12 in OSS can still use that version as they see fit, and then when that PR is merged, the changes will be reflected in 0.1.14 (or whatever version is next when it goes in) for both cloud and OSS users. Does that sound good @evantahler?

I suppose I'd add the changelog entry from 0.1.12 too, and make it clear that 0.1.13 reverts those changes

evantahler · 2023-01-30T21:47:36Z

However, cloud is still seeing 0.1.11, since the cloud catalog was never updated, since the PR was merged. Therefore cloud users should see no effects of going from 0.1.11 to 0.1.13. Users who want 0.1.12 in OSS can still use that version as they see fit, and then when that PR is merged, the changes will be reflected in 0.1.14 (or whatever version is next when it goes in) for both cloud and OSS users. Does that sound good @evantahler?

Yep! Although, it's a shame we got into this position.

Alternatively, you could merge in #20973 and then merge this after?

erohmensing · 2023-01-30T22:01:16Z

I would, except for the fact that the acceptance tests went from consistently succeeding to consistently failing. I think that PR needs some more work before it goes in 😕 will run tests on that branch

erohmensing · 2023-01-30T22:02:35Z

Actually, now that I think about it, it seems weird that the connector would start failing tests on the #connector-health check since they're built off of master. So maybe that is actually unrelated, though it started failing on the 19th, when the new version was released... confusion abounds

erohmensing · 2023-01-31T20:42:06Z

Merged the contributor PR - someone had already released a newer version. Releasing this version should re-introduce the contributor's changes lost in the 1.0.0 version as well as add my changes.

erohmensing · 2023-01-31T20:42:47Z

/publish connector=connectors/source-marketo run-tests=false

🕑 Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4058180228

Connector	Did it publish?	Were definitions generated?
connectors/source-marketo	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-01-31T21:07:33Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.51%	❌

Turn off default for source-marketo (GA)

f789144

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo labels Jan 27, 2023

erohmensing requested a review from a team January 27, 2023 21:51

erohmensing changed the title ~~Turn off default for source-marketo (GA)~~ Turn off default httpavailabilitystrategy for source-marketo (GA) Jan 27, 2023

erohmensing added 2 commits January 27, 2023 17:24

Update source.py

56944a3

Update marketo.md

7dda0fe

evantahler approved these changes Jan 27, 2023

View reviewed changes

evantahler mentioned this pull request Jan 30, 2023

🐛 Source Marketo: fix encoding error for Lead sync #20973

Merged

14 tasks

Merge branch 'master' into AS-source-marketo

f6cacfc

auto-bump connector version

351884b

erohmensing enabled auto-merge (squash) January 31, 2023 20:57

octavia-squidington-iii temporarily deployed to more-secrets January 31, 2023 20:59 — with GitHub Actions Inactive

erohmensing merged commit 2c97aa3 into master Jan 31, 2023

erohmensing deleted the AS-source-marketo branch January 31, 2023 21:29

octavia-squidington-iii mentioned this pull request Feb 2, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22335

Closed

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn off default httpavailabilitystrategy for source-marketo (GA) #22015

Turn off default httpavailabilitystrategy for source-marketo (GA) #22015

erohmensing commented Jan 27, 2023 •

edited

Loading

erohmensing commented Jan 27, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 28, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 28, 2023

evantahler commented Jan 28, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 •

edited

Loading

evantahler commented Jan 30, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 •

edited

Loading

erohmensing commented Jan 31, 2023

erohmensing commented Jan 31, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 31, 2023

Turn off default httpavailabilitystrategy for source-marketo (GA) #22015

Turn off default httpavailabilitystrategy for source-marketo (GA) #22015

Conversation

erohmensing commented Jan 27, 2023 • edited Loading

erohmensing commented Jan 27, 2023 • edited by github-actions bot Loading

Build Failed

erohmensing commented Jan 28, 2023 • edited by github-actions bot Loading

Build Failed

erohmensing commented Jan 28, 2023

evantahler commented Jan 28, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 • edited by github-actions bot Loading

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 • edited Loading

evantahler commented Jan 30, 2023

erohmensing commented Jan 30, 2023

erohmensing commented Jan 30, 2023 • edited Loading

erohmensing commented Jan 31, 2023

erohmensing commented Jan 31, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 31, 2023

Airbyte Code Coverage

erohmensing commented Jan 27, 2023 •

edited

Loading

erohmensing commented Jan 27, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 28, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 30, 2023 •

edited by github-actions bot

Loading

erohmensing commented Jan 30, 2023 •

edited

Loading

erohmensing commented Jan 30, 2023 •

edited

Loading

erohmensing commented Jan 31, 2023 •

edited by github-actions bot

Loading