🎉 Source TikTok Marketing - Add country_code and platform audience reports #22134

roisinbolt · 2023-01-31T10:31:26Z

What

In order to use the TikTok Marketing Audience report effectively we need to have a view of the country_code and platform level in ad pulls.

#22064

How

Both country_code and platform are available dimensions in the Audience Report.

In the current Airbyte connector for TikTok Marketing CampaignsAudienceReportsByCountry has been added as an available stream. I would like to expand the approach taken for this stream to have reports ByCountry and ByPlatform for all id levels (ad, adgroup, campaign, advertiser).

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

…split

…hub.com:roisinbolt/airbyte into roisin-tiktok-basicreport-non-temp-id-dim-split

marcosmarxm · 2023-02-02T09:08:39Z

Thanks for the contribution @roisinbolt I'll take a look later today.

roisinbolt · 2023-02-02T09:12:42Z

@marcosmarxm Thanks! I don't have productions credentials locally to test part of the acceptance test suite.

misteryeo · 2023-02-02T22:25:27Z

Issue was linked to Harvestr Discovery: Source TikTok Marketing: Add country_code and platform Audience Reports

roisinbolt · 2023-02-08T14:30:04Z

Hey @marcosmarxm , just wanted to check in on when you'll have a chance to review this PR?

roisinbolt · 2023-02-13T11:58:06Z

Hey @misteryeo , do you have any context on where this PR sits in the review backlog?

marcosmarxm · 2023-02-13T16:40:28Z

Sorry the delay @roisinbolt adding this to my priority list!
@sh4sh fyi too!

roisinbolt · 2023-02-20T09:23:30Z

Hey @marcosmarxm ! I was just wondering if you have an idea of when this will start being reviewed? Just whether it will be this week/next week?

marcosmarxm · 2023-02-21T22:43:59Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4237521533
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4237521533
🐛 https://gradle.com/s/fthiqhut5tysq

Build Failed

Test summary info:

Could not find result summary

marcosmarxm · 2023-02-21T22:49:46Z

@midavadim can you check this contribution?

roisinbolt · 2023-03-09T16:51:13Z

@marcosmarxm @midavadim Is there any update on when this will be reviewed?

roisinbolt · 2023-03-29T13:37:29Z

Hey @marcosmarxm @midavadim @sh4sh @misteryeo

It has been ~2months since this contribution was originally opened in a PR - it would be helpful to understand any changes I need to make and/or get it merged in to the repo.

bazarnov · 2023-03-30T12:54:38Z

@roisinbolt Hello, could you please update your branch and PR up to the latest master and fix the conflicts, so we can move forward? I've assigned myself here as a reviewer for a fast review. Your contribution seems reasonable and we would like to have it the part of the newest TikTok release we're preparing these days.

…icreport-non-temp-id-dim-split

roisinbolt · 2023-03-30T13:26:05Z

@bazarnov Thanks for picking this up! That is done there

roisinbolt · 2023-04-04T10:46:17Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

bazarnov · 2023-04-04T10:47:25Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

Please add them all, we'll clean up later on.

roisinbolt · 2023-04-04T10:51:36Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

Please add them all, we'll clean up later on.

Okay I will do this now. Could you please link me to where you are seeing this failure?

bazarnov · 2023-04-04T11:05:35Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

Please add them all, we'll clean up later on.

Okay I will do this now. Could you please link me to where you are seeing this failure?

https://github.com/airbytehq/airbyte/actions/runs/4606074652/jobs/8138956687 (not sure you can see those logs)

roisinbolt · 2023-04-04T11:12:30Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

Please add them all, we'll clean up later on.

Okay I will do this now. Could you please link me to where you are seeing this failure?

https://github.com/airbytehq/airbyte/actions/runs/4606074652/jobs/8138956687 (not sure you can see those logs)

yes I can see those thanks! The _hourly empty_streams being missing looks like a WARN so should be fine without those, but I have added in all the suggested ones now.

bazarnov · 2023-04-04T11:18:38Z

As per this PR _hourly granularity for audience reports is deprecated so I think we shouldn't have to add that granularity split? I can add in the daily.

Please add them all, we'll clean up later on.

Okay I will do this now. Could you please link me to where you are seeing this failure?

https://github.com/airbytehq/airbyte/actions/runs/4606074652/jobs/8138956687 (not sure you can see those logs)

yes I can see those thanks! The _hourly empty_streams being missing looks like a WARN so should be fine without those, but I have added in all the suggested ones now.

Thank you!

Also, please change the version from 2.0.5 > 2.0.6 here: https://github.com/roisinbolt/airbyte/blob/roisin-tiktok-basicreport-non-temp-id-dim-split/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile#L35

bazarnov · 2023-04-04T18:02:52Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4610867448
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4610867448
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/source.py        68      7    90%
source_tiktok_marketing/streams.py      390     41    89%
---------------------------------------------------------
TOTAL                                   460     48    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 91 passed, 2 skipped in 3382.22s (0:56:22) ==================

…split

bazarnov · 2023-04-04T19:14:01Z

Also, please change the version from 2.0.5 > 2.0.6 here: https://github.com/roisinbolt/airbyte/blob/roisin-tiktok-basicreport-non-temp-id-dim-split/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile#L35

@roisinbolt we're currently waiting for this final change, before the merge.

…hub.com:roisinbolt/airbyte into roisin-tiktok-basicreport-non-temp-id-dim-split

roisinbolt · 2023-04-05T08:09:09Z

@bazarnov that should be done there! The change was sitting on my local and I thought it had been pushed 😅

docs/integrations/sources/tiktok-marketing.md

bazarnov · 2023-04-05T11:04:07Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4617784877
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/4617784877
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/source.py        68      7    90%
source_tiktok_marketing/streams.py      390     41    89%
---------------------------------------------------------
TOTAL                                   460     48    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 91 passed, 2 skipped in 3271.74s (0:54:31) ==================

…split

bazarnov · 2023-04-05T12:17:39Z

@airbytehq/connector-extensibility @airbytehq/connector-operations I'm going to merge this contribution today. There are no breaking changes, but enhancements only. Just FYI.

bazarnov · 2023-04-05T12:26:00Z

/publish connector=connectors/source-tiktok-marketing

🕑 Publishing the following connectors:
connectors/source-tiktok-marketing
https://github.com/airbytehq/airbyte/actions/runs/4618441692

Connector	Did it publish?	Were definitions generated?
connectors/source-tiktok-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

roisinbolt · 2023-04-05T12:56:31Z

@bazarnov Thanks for your help on this!

bazarnov · 2023-04-05T13:49:47Z

@marcosmarxm @evantahler Could you please take a look at how we could merge this PR? The publish+auto bump was successful. Now, to merge this in we need to pass CI checks, and this is apparently the blocker.

Source TikTok Marketing - Add country_code and platform audience reports

6b58001

octavia-squidington-iv added area/connectors Connector related issues community connectors/source/tiktok-marketing labels Jan 31, 2023

roisinbolt changed the title ~~Source TikTok Marketing - Add country_code and platform audience reports~~ 🎉 Source TikTok Marketing - Add country_code and platform audience reports Jan 31, 2023

roisinbolt marked this pull request as ready for review January 31, 2023 16:20

octavia-squidington-iv added the bounty label Jan 31, 2023

roisinbolt mentioned this pull request Jan 31, 2023

Source TikTok Marketing: Add country_code and platform Audience Reports #22064

Closed

roisinbolt added 2 commits January 31, 2023 16:47

update README and acceptance-test-config

b144022

Merge branch 'master' into roisin-tiktok-basicreport-non-temp-id-dim-…

94aef46

…split

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 31, 2023

roisinbolt added 2 commits January 31, 2023 16:50

Update bootstrap.md

3250a66

Merge branch 'roisin-tiktok-basicreport-non-temp-id-dim-split' of git…

c666a5e

…hub.com:roisinbolt/airbyte into roisin-tiktok-basicreport-non-temp-id-dim-split

sajarin requested a review from midavadim February 1, 2023 16:35

update extend statement/

4a6c508

bazarnov self-requested a review March 30, 2023 12:49

Merge remote-tracking branch 'upstream/master' into roisin-tiktok-bas…

bccc773

…icreport-non-temp-id-dim-split

change empty_streams to specify daily granularity

d305d67

add extra empty_streams for acceptance tests

659c43e

airbyte.version=2.0.6

c8bc475

Merge branch 'master' into roisin-tiktok-basicreport-non-temp-id-dim-…

75af14c

…split

Merge branch 'roisin-tiktok-basicreport-non-temp-id-dim-split' of git…

fa984f2

…hub.com:roisinbolt/airbyte into roisin-tiktok-basicreport-non-temp-id-dim-split

bazarnov reviewed Apr 5, 2023

View reviewed changes

docs/integrations/sources/tiktok-marketing.md Outdated Show resolved Hide resolved

roisinbolt commented Apr 5, 2023

View reviewed changes

docs/integrations/sources/tiktok-marketing.md Outdated Show resolved Hide resolved

Update docs/integrations/sources/tiktok-marketing.md

86bfe40

Merge branch 'master' into roisin-tiktok-basicreport-non-temp-id-dim-…

347bea7

…split

bazarnov approved these changes Apr 5, 2023

View reviewed changes

auto-bump connector version

de0e185

bazarnov enabled auto-merge (squash) April 5, 2023 13:47

bazarnov disabled auto-merge April 5, 2023 13:47

bazarnov requested a review from a team April 5, 2023 14:11

marcosmarxm merged commit 32fb8c2 into airbytehq:master Apr 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source TikTok Marketing - Add country_code and platform audience reports #22134

🎉 Source TikTok Marketing - Add country_code and platform audience reports #22134

roisinbolt commented Jan 31, 2023 •

edited

Loading

marcosmarxm commented Feb 2, 2023

roisinbolt commented Feb 2, 2023

misteryeo commented Feb 2, 2023

roisinbolt commented Feb 8, 2023

roisinbolt commented Feb 13, 2023

marcosmarxm commented Feb 13, 2023

roisinbolt commented Feb 20, 2023

marcosmarxm commented Feb 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 21, 2023

roisinbolt commented Mar 9, 2023

roisinbolt commented Mar 29, 2023

bazarnov commented Mar 30, 2023

roisinbolt commented Mar 30, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

bazarnov commented Apr 4, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 5, 2023

bazarnov commented Apr 5, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 5, 2023

bazarnov commented Apr 5, 2023 •

edited by github-actions bot

Loading

roisinbolt commented Apr 5, 2023

bazarnov commented Apr 5, 2023

🎉 Source TikTok Marketing - Add country_code and platform audience reports #22134

🎉 Source TikTok Marketing - Add country_code and platform audience reports #22134

Conversation

roisinbolt commented Jan 31, 2023 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

marcosmarxm commented Feb 2, 2023

roisinbolt commented Feb 2, 2023

misteryeo commented Feb 2, 2023

roisinbolt commented Feb 8, 2023

roisinbolt commented Feb 13, 2023

marcosmarxm commented Feb 13, 2023

roisinbolt commented Feb 20, 2023

marcosmarxm commented Feb 21, 2023 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Feb 21, 2023

roisinbolt commented Mar 9, 2023

roisinbolt commented Mar 29, 2023

bazarnov commented Mar 30, 2023

roisinbolt commented Mar 30, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 4, 2023

bazarnov commented Apr 4, 2023

bazarnov commented Apr 4, 2023 • edited by github-actions bot Loading

Build Passed

bazarnov commented Apr 4, 2023

roisinbolt commented Apr 5, 2023

bazarnov commented Apr 5, 2023 • edited by github-actions bot Loading

Build Passed

bazarnov commented Apr 5, 2023

bazarnov commented Apr 5, 2023 • edited by github-actions bot Loading

roisinbolt commented Apr 5, 2023

bazarnov commented Apr 5, 2023

roisinbolt commented Jan 31, 2023 •

edited

Loading

marcosmarxm commented Feb 21, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 4, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 5, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 5, 2023 •

edited by github-actions bot

Loading