Source Freshdesk: add availability strategy #22145

roman-yermilov-gl · 2023-01-31T14:44:11Z

What

Add availability strategy

roman-yermilov-gl · 2023-01-31T15:03:27Z

/test connector=connectors/source-freshdesk

roman-yermilov-gl · 2023-02-02T11:27:36Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4074002400
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4074002400
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        26      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      226      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            274      4    99%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 336.91s (0:05:36) ===================

github-actions · 2023-02-03T12:28:10Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.53%	❌

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

airbyte-integrations/connectors/source-freshdesk/integration_tests/expected_records.jsonl

erohmensing · 2023-02-03T21:00:17Z

There is also custom handling for 403s in the should_retry method - I think we can remove that now!

We want to look for these and remove them as we implement AvailabilityStrategy, but I've shortlisted all the ones I noticed here for easier reference

roman-yermilov-gl · 2023-02-06T15:42:17Z

There is also custom handling for 403s in the should_retry method - I think we can remove that now!

We want to look for these and remove them as we implement AvailabilityStrategy, but I've shortlisted all the ones I noticed here for easier reference

Removed

erohmensing

LGTM - thank you!

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

roman-yermilov-gl · 2023-02-06T16:58:52Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4105995032
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4105995032
Python tests coverage:

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_freshdesk/source.py                     22      0   100%
source_freshdesk/availability_strategy.py      10      0   100%
source_freshdesk/__init__.py                    2      0   100%
source_freshdesk/streams.py                   224      4    98%
source_freshdesk/utils.py                      20      1    95%
---------------------------------------------------------------
TOTAL                                         278      5    98%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 457.91s (0:07:37) ===================

roman-yermilov-gl · 2023-02-06T17:53:35Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/4106452151

Connector	Did it publish?	Were definitions generated?

roman-yermilov-gl · 2023-02-07T11:51:35Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/4113578387

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

roman-yermilov-gl · 2023-02-07T13:03:02Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/4114166328

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source FreshDesk: start using availability strategy * Source FreshDesk: fix flake issues * Source Freshdesk: update version * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

octavia-squidington-iv added connectors/source/freshdesk area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 31, 2023

lazebnyi changed the title ~~Ryermilov/source freshdesk add availability strategy~~ Source Freshdesk: add availability strategy Jan 31, 2023

roman-yermilov-gl force-pushed the ryermilov/source-freshdesk-add-availability-strategy branch from 8e03c85 to d253fc0 Compare February 2, 2023 11:24

roman-yermilov-gl requested a review from lazebnyi February 2, 2023 11:28

roman-yermilov-gl self-assigned this Feb 2, 2023

roman-yermilov-gl requested a review from pedroslopez February 2, 2023 12:48

lazebnyi approved these changes Feb 2, 2023

View reviewed changes

lazebnyi requested review from erohmensing, brianjlai and maxi297 February 2, 2023 14:58

roman-yermilov-gl temporarily deployed to more-secrets February 3, 2023 12:20 — with GitHub Actions Inactive

erohmensing requested changes Feb 3, 2023

View reviewed changes

roman-yermilov-gl requested a review from erohmensing February 6, 2023 15:43

roman-yermilov-gl force-pushed the ryermilov/source-freshdesk-add-availability-strategy branch from 4362c5c to 0fec2ba Compare February 6, 2023 16:29

roman-yermilov-gl temporarily deployed to more-secrets February 6, 2023 16:31 — with GitHub Actions Inactive

roman-yermilov-gl temporarily deployed to more-secrets February 6, 2023 16:45 — with GitHub Actions Inactive

roman-yermilov-gl temporarily deployed to more-secrets February 6, 2023 16:46 — with GitHub Actions Inactive

erohmensing approved these changes Feb 6, 2023

View reviewed changes

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py Show resolved Hide resolved

roman-yermilov-gl force-pushed the ryermilov/source-freshdesk-add-availability-strategy branch from be3722f to f75fa5c Compare February 7, 2023 12:59

roman-yermilov-gl added 3 commits February 7, 2023 17:01

Source FreshDesk: start using availability strategy

81b54ce

Source FreshDesk: fix flake issues

02594ed

Source Freshdesk: update version

f75fa5c

roman-yermilov-gl temporarily deployed to more-secrets February 7, 2023 13:01 — with GitHub Actions Inactive

roman-yermilov-gl temporarily deployed to more-secrets February 7, 2023 13:02 — with GitHub Actions Inactive

auto-bump connector version

41d76b1

airbyteio temporarily deployed to more-secrets February 7, 2023 13:29 — with GitHub Actions Inactive

roman-yermilov-gl merged commit cf5a0ee into master Feb 7, 2023

roman-yermilov-gl deleted the ryermilov/source-freshdesk-add-availability-strategy branch February 7, 2023 14:41

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.30 #22506

Closed

octavia-squidington-iii mentioned this pull request Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

This was referenced Feb 10, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Freshdesk: add availability strategy #22145

Source Freshdesk: add availability strategy #22145

roman-yermilov-gl commented Jan 31, 2023

roman-yermilov-gl commented Jan 31, 2023

roman-yermilov-gl commented Feb 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

erohmensing commented Feb 3, 2023

roman-yermilov-gl commented Feb 6, 2023

erohmensing left a comment

roman-yermilov-gl commented Feb 6, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 6, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

Source Freshdesk: add availability strategy #22145

Source Freshdesk: add availability strategy #22145

Conversation

roman-yermilov-gl commented Jan 31, 2023

What

roman-yermilov-gl commented Jan 31, 2023

roman-yermilov-gl commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Feb 3, 2023 • edited Loading

Airbyte Code Coverage

erohmensing commented Feb 3, 2023

roman-yermilov-gl commented Feb 6, 2023

erohmensing left a comment

Choose a reason for hiding this comment

roman-yermilov-gl commented Feb 6, 2023 • edited by github-actions bot Loading

Build Passed

roman-yermilov-gl commented Feb 6, 2023 • edited by github-actions bot Loading

roman-yermilov-gl commented Feb 7, 2023 • edited by github-actions bot Loading

roman-yermilov-gl commented Feb 7, 2023 • edited by github-actions bot Loading

roman-yermilov-gl commented Feb 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

roman-yermilov-gl commented Feb 6, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 6, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading

roman-yermilov-gl commented Feb 7, 2023 •

edited by github-actions bot

Loading