Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons passed to Button component must be wrapped in a div for proper styling #22176

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Icons passed to Button component must be wrapped in a div for proper styling #22176

merged 1 commit into from
Feb 6, 2023

Conversation

matter-q
Copy link
Contributor

@matter-q matter-q commented Jan 31, 2023 •
edited
Loading

What

Closes #18581

How

Added property className for Rotate Icon component to support class attribute

image

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 31, 2023
@matter-q
Copy link
Contributor Author

As I see it, we're not actually passing a simple <svg> tag, we're passing a React component that doesn't have the described className notation, so that's why <div> wrapper is a working solution.

What do you think @lmossman , @tealjulia, @edmundito ?

@matter-q matter-q requested a review from dizel852 January 31, 2023 22:12
@dizel852
Copy link
Contributor

dizel852 commented Feb 1, 2023

Hmm.. seems like this issue is part of #20133.
Since atm, we don't have a consistent <Icon /> component to handle all the available icons.

dizel852
dizel852 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - LGTM 👍

Passing to @edmundito

@dizel852 dizel852 requested a review from edmundito February 1, 2023 12:52
@matter-q matter-q force-pushed the mark/icons-passed-to-Button-component-must-be-wrapped-in-a-div-for-proper-styling branch from a69ab00 to f27128c Compare February 6, 2023 16:01
Icons passed to Button component must be wrapped in a div for proper …
828c0f2 
…styling

- Added property notation for Rotate Icon to support className attribute
@matter-q matter-q force-pushed the mark/icons-passed-to-Button-component-must-be-wrapped-in-a-div-for-proper-styling branch from f27128c to 828c0f2 Compare February 6, 2023 18:05
@matter-q matter-q merged commit 015174a into master Feb 6, 2023
@matter-q matter-q deleted the mark/icons-passed-to-Button-component-must-be-wrapped-in-a-div-for-proper-styling branch February 6, 2023 18:33
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizel852 dizel852 dizel852 approved these changes

@edmundito edmundito edmundito approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons passed to Button component must be wrapped in a div for proper styling
4 participants
@matter-q @dizel852 @edmundito @octavia-squidington-iv