Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sync_mode as incremental instead of full refresh in catalog speci… #22183

Merged

Conversation

prateekmukhedkar
Copy link
Contributor

Set sync_mode as incremental instead of full refresh in incremental catalog.

What

Fix sync_mode parameters in incremental_configured_catalog.json so that source does an incremental sync instead of full refresh.

How

This change simply updates incremental_configured_catalog.json with the correct value for sync_mode so that an incremental sync is done. There are no changes needed in source.py.

Verified the changes by running the following command which is present in the adding incremental sync to source tutorial and seeing that new state gets printed:

python source.py read --config secrets/valid_config.json --catalog incremental_configured_catalog.json --state state.json

Recommended reading order

build-a-connector-the-hard-way.md
adding-incremental-sync.md

🚨 User Impact 🚨

Users following the guide will be able to complete the tutorial on how to add incremental sync when building source connectors.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


prateekmukhedkar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Feb 1, 2023
@prateekmukhedkar prateekmukhedkar self-assigned this Feb 1, 2023
@prateekmukhedkar prateekmukhedkar merged commit 531627e into master Feb 7, 2023
@prateekmukhedkar prateekmukhedkar deleted the prateekmukhedkar/fix-adding-incremental-connector branch February 7, 2023 23:37
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
…fying incremental sync (airbytehq#22183)

Co-authored-by: prateekmukhedkar <prateek@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants