Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout entire git history in test-command #22184

Merged
merged 11 commits into from
Feb 7, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Feb 1, 2023

What

We were seeing a failure as the git history was not available.

Fix #22127

How

I believe the issue is that we didnt have the full history of the project.

This PR should let us test that that is true as we download full history

🚨 User Impact 🚨

This could result in longer than acceptable build times

Pre-merge Checklist

  • Check that the qa-engine step runs successfully by running the Integration action on this branch
  • Compare the run time against an integration test on master
  • Discuss the impact with the @airbytehq/connector-operations team

Post-merge Checklist

  • Remove the branch conditional in test-command.yml
  • Update report.sh to use the QA_CHECKS_OUTCOME argument again

@bnchrch bnchrch requested a review from a team February 1, 2023 00:08
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4059525463
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4059525463
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestSpec.test_config_match_spec: The spec is currently invalid: it has additionalProperties set to false
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not support incremental syncs.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
======================== 12 passed, 3 skipped in 10.28s ========================

@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 00:10 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 00:10 — with GitHub Actions Inactive
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52%

@evantahler
Copy link
Contributor

evantahler commented Feb 1, 2023

It didn't get slower!

Screenshot 2023-01-31 at 4 20 39 PM

EDIT: I'm not sure your depth=0 change took effect. Maybe this only uses the version of the action on master?

@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 00:24 — with GitHub Actions Inactive
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

@evantahler Always hot on my heels!

Youre right it didnt run with the updated config.

But I just triggered a new build targeting the new workflow here: https://github.com/airbytehq/airbyte/actions/runs/4059601806/workflow

So we will see!

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

It still failed 🤔

@evantahler
Copy link
Contributor

I recently added the CWD change, which I think should be having no effect, but that could be wrong -

# ensure we are at the repository root
os.chdir(os.path.dirname(os.path.abspath(__file__)))
os.chdir('../../..')

@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 21:24 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 21:24 — with GitHub Actions Inactive
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

/test connector=connectors/source-faker gitref=bechurch/feat-qa-engine-22127-git-history

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4068851423
❌ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4068851423
🐛 https://gradle.com/s/723cim66f25hi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 1 failed, 34 passed, 2 skipped in 34.51s ===================

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

/test connector=connectors/source-pokeapi gitref=bechurch/feat-qa-engine-22127-git-history

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4069078002
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4069078002
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestSpec.test_config_match_spec: The spec is currently invalid: it has additionalProperties set to false
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not support incremental syncs.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
======================== 12 passed, 3 skipped in 9.24s =========================

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 1, 2023

New build in progress https://github.com/airbytehq/airbyte/actions/runs/4069882520

Had assumed the above command would have ran the qa-engine test like expected.

@bnchrch bnchrch temporarily deployed to more-secrets February 1, 2023 23:48 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 00:06 — with GitHub Actions Inactive
@bnchrch bnchrch force-pushed the bechurch/feat-qa-engine-22127-git-history branch from 9765f22 to fc7bebd Compare February 2, 2023 03:00
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 2, 2023

Running another action: https://github.com/airbytehq/airbyte/actions/runs/4071070930

Basically reverted to the original. I want to see the current working directory this is running at.

@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:01 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:02 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:02 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:47 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:47 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 03:48 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 20:48 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:17 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:17 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:17 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:38 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:38 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 21:38 — with GitHub Actions Inactive
@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 2, 2023

@airbytehq/connector-operations Sorry for all the pings.

This should be now ready for review!

QA Checks are back! https://github.com/airbytehq/airbyte/actions/runs/4078879071

@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 22:03 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets February 2, 2023 22:03 — with GitHub Actions Inactive
Comment on lines -19 to +13
AIRBYTE_REPO = git.Repo(".")
AIRBYTE_REPO = git.Repo(search_parent_directories=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course - the magic option was set to False...
Would this still work if we added back the os.chdir('../../..')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not unfortunately.

The issue here came down to the file found it self in different directories and running contexts.

So change the directory via a relative path would always break one of local or ec2

On local the paths were:

  • current working directory: /Users/ben/Development/repos/airbyte/tools/ci_connector_ops
  • file directory: /Users/ben/Development/repos/airbyte/tools/ci_connector_ops/ci_connector_ops

On the ec2 instance the paths were (taken from a workflow we ran):

  • The current working directory was /actions-runner/_work/airbyte/airbyte
  • And the files path was /actions-runner/_work/_tool/Python/3.9.16/x64/lib/python3.9/site-packages/ci_connector_ops/utils.py

So our best way seems to be relying on using the GitPython library to simply traverse up the directory structure until it finds a .git folder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shall pass this repo path as an env var for a more explicit definition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Thinking on that a bit. Perhaps if theres is a case where we would not be inside a git versioned directory.

@alafanechere Is there a context that might happen?

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice debugging 🧐

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicit path definition via env var would make this more stable and flexible in the long run. Feel free to add it to the PR if you like this suggestion, LGTM otherwise.

Comment on lines -19 to +13
AIRBYTE_REPO = git.Repo(".")
AIRBYTE_REPO = git.Repo(search_parent_directories=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shall pass this repo path as an env var for a more explicit definition

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 7, 2023

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4109420261
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4109420261
Python tests coverage:

	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:22: `future_state` has a bypass reason, skipping.
================== 66 passed, 6 skipped in 716.65s (0:11:56) ===================

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 7, 2023

/test connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/4109423976
✅ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/4109423976
Python tests coverage:

	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:30: `future_state` not specified, skipping.
======================== 34 passed, 2 skipped in 53.80s ========================

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 7, 2023

Running a couple more tests before merge

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 7, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4115871202
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4115871202
🐛 https://gradle.com/s/tyi5wiwg7j3re

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream proje...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 1 failed, 34 passed, 2 skipped in 44.55s ===================

@bnchrch
Copy link
Contributor Author

bnchrch commented Feb 7, 2023

/test connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/4115876679
✅ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/4115876679
Python tests coverage:

	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:30: `future_state` not specified, skipping.
======================== 34 passed, 2 skipped in 53.29s ========================

@bnchrch bnchrch merged commit 35ea6e9 into master Feb 7, 2023
@bnchrch bnchrch deleted the bechurch/feat-qa-engine-22127-git-history branch February 7, 2023 17:08
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qa_checks.py crashing in /test commands
4 participants