Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test card from empty actor form #22199

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

flash1293
Copy link
Contributor

What

This PR removes the "Test" CTA from the empty source/destination form to make it more likely for the user to succeed setting up their connection (related discussion here: #21698 (comment) )

How

  • When in edit mode:
    • Always show test card with "Retest" button to retest saved state
    • Disable "Retest" button if the form is dirty
  • When in new mode:
    • Only show test card if testing is in progress or was successful/failed
    • Do not show a "Test" button
    • Show a cancel button (disabled if the connection test is not in progress)

https://www.loom.com/share/58ec66cb14d241809881d7480b1bb211

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Feb 1, 2023
@flash1293 flash1293 marked this pull request as ready for review February 1, 2023 11:04
@flash1293 flash1293 requested a review from lmossman February 1, 2023 11:04
@flash1293
Copy link
Contributor Author

cc @timroes

Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected. Code LGTM. Minor nitpick: the error icon can squeeze (not directly related, but easy to fix as part of this PR).

@flash1293
Copy link
Contributor Author

@nataliekwong could you check out this fix?

@nataliekwong
Copy link
Contributor

@flash1293 Thanks! Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants