Source mysql: handle ssh connection refused issue #22205

sashaNeshcheret · 2023-02-01T13:09:59Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

sashaNeshcheret · 2023-02-01T13:11:12Z

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4064713100
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4064713100
No Python unittests run

Build Passed

Test summary info:

All Passed

sashaNeshcheret · 2023-02-01T13:11:39Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4064718750
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4064718750
🐛 https://gradle.com/s/sgwkioti4xtbe

Build Failed

Test summary info:

Could not find result summary

github-actions · 2023-02-01T13:12:37Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (31)

Connector	Version	Changelog	Publish
`source-alloydb`	`1.0.36`	✅	✅
`source-alloydb-strict-encrypt`	`1.0.36`	🔵 (ignored)	🔵 (ignored)
`source-bigquery`	`0.2.3`	✅	✅
`source-clickhouse`	`0.1.15`	✅	✅
`source-clickhouse-strict-encrypt`	`0.1.15`	🔵 (ignored)	🔵 (ignored)
`source-cockroachdb`	`0.1.19`	✅	✅
`source-cockroachdb-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`source-db2`	`0.1.17`	✅	✅
`source-db2-strict-encrypt`	`0.1.17`	🔵 (ignored)	🔵 (ignored)
`source-dynamodb`	`0.1.0`	✅	✅
`source-e2e-test`	`2.1.3`	✅	✅
`source-e2e-test-cloud`	`2.1.1`	🔵 (ignored)	🔵 (ignored)
`source-elasticsearch`	`0.1.1`	✅	✅
`source-jdbc`	`0.3.5`	🔵 (ignored)	🔵 (ignored)
`source-kafka`	`0.2.3`	✅	✅
`source-mongodb-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`source-mongodb-v2`	`0.1.19`	✅	✅
`source-mssql`	`0.4.28`	✅	✅
`source-mssql-strict-encrypt`	`0.4.28`	🔵 (ignored)	🔵 (ignored)
`source-mysql`	`1.0.21`	✅	✅
`source-mysql-strict-encrypt`	`1.0.21`	🔵 (ignored)	🔵 (ignored)
`source-oracle`	`0.3.22`	✅	✅
`source-oracle-strict-encrypt`	`0.3.22`	🔵 (ignored)	🔵 (ignored)
`source-postgres`	`1.0.42`	✅	✅
`source-postgres-strict-encrypt`	`1.0.42`	🔵 (ignored)	🔵 (ignored)
`source-redshift`	`0.3.16`	✅	✅
`source-relational-db`	`0.3.1`	🔵 (ignored)	🔵 (ignored)
`source-scaffold-java-jdbc`	`0.1.0`	🔵 (ignored)	🔵 (ignored)
`source-sftp`	`0.1.2`	✅	✅
`source-snowflake`	`0.1.29`	✅	✅
`source-tidb`	`0.2.2`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (47)

Connector	Version	Changelog	Publish
`destination-azure-blob-storage`	`0.1.6`	✅	✅
`destination-bigquery`	`1.2.13`	✅	✅
`destination-bigquery-denormalized`	`1.2.12`	✅	❌ (diff seed version)
`destination-cassandra`	`0.1.4`	✅	✅
`destination-clickhouse`	`0.2.2`	❌ (changelog missing)	✅
`destination-clickhouse-strict-encrypt`	`0.2.2`	🔵 (ignored)	🔵 (ignored)
`destination-csv`	`1.0.0`	❌ (changelog missing)	✅
`destination-databricks`	`0.3.1`	✅	✅
`destination-dev-null`	`0.2.7`	🔵 (ignored)	🔵 (ignored)
`destination-doris`	`0.1.0`	✅	✅
`destination-dynamodb`	`0.1.7`	✅	✅
`destination-e2e-test`	`0.2.4`	✅	✅
`destination-elasticsearch`	`0.1.6`	✅	✅
`destination-elasticsearch-strict-encrypt`	`0.1.6`	🔵 (ignored)	🔵 (ignored)
`destination-gcs`	`0.2.14`	✅	✅
`destination-iceberg`	`0.1.0`	✅	✅
`destination-jdbc`	`0.3.14`	🔵 (ignored)	🔵 (ignored)
`destination-kafka`	`0.1.10`	✅	✅
`destination-keen`	`0.2.4`	✅	✅
`destination-kinesis`	`0.1.5`	✅	✅
`destination-local-json`	`0.2.11`	✅	✅
`destination-mariadb-columnstore`	`0.1.7`	✅	✅
`destination-mongodb`	`0.1.9`	✅	✅
`destination-mongodb-strict-encrypt`	`0.1.9`	🔵 (ignored)	🔵 (ignored)
`destination-mqtt`	`0.1.3`	✅	✅
`destination-mssql`	`0.1.22`	✅	✅
`destination-mssql-strict-encrypt`	`0.1.22`	🔵 (ignored)	🔵 (ignored)
`destination-mysql`	`0.1.20`	✅	✅
`destination-mysql-strict-encrypt`	❌ `0.1.21` (mismatch: `0.1.20`)	🔵 (ignored)	🔵 (ignored)
`destination-oracle`	`0.1.19`	✅	✅
`destination-oracle-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`destination-postgres`	`0.3.26`	✅	✅
`destination-postgres-strict-encrypt`	`0.3.26`	🔵 (ignored)	🔵 (ignored)
`destination-pubsub`	`0.2.0`	✅	✅
`destination-pulsar`	`0.1.3`	✅	✅
`destination-r2`	`0.1.0`	✅	✅
`destination-redis`	`0.1.4`	✅	✅
`destination-redpanda`	`0.1.0`	✅	✅
`destination-redshift`	`0.3.56`	✅	✅
`destination-rockset`	`0.1.4`	✅	✅
`destination-s3`	`0.3.19`	✅	✅
`destination-s3-glue`	`0.1.1`	✅	✅
`destination-scylla`	`0.1.3`	✅	✅
`destination-snowflake`	`0.4.47`	✅	✅
`destination-teradata`	`0.1.0`	✅	✅
`destination-tidb`	`0.1.0`	✅	✅
`destination-yugabytedb`	`0.1.0`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

…onnection-refused

jbfbell · 2023-02-01T22:56:45Z

...e-integrations/bases/base-java/src/main/java/io/airbyte/integrations/base/ssh/SshTunnel.java

-          .toLowerCase(Locale.ROOT)
-          .contains("failed to get operation result within specified timeout")) {
+      if (e instanceof SshException &&
+          (isTimeout(e) || e.getMessage().contains("Failed (ConnectException) to execute: Connection refused"))) {


Since both of these conditions result in a timeout config error exception, I think it makes sense to wrap all the logic into your isTimeout method

…ndle-ssh-connection-refused' into omneshcheret/670-mysql-source-handle-ssh-connection-refused

…sql-source-handle-ssh-connection-refused

sashaNeshcheret · 2023-02-03T08:38:38Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4082475191
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4082475191
🐛 https://gradle.com/s/c56hfhtu6sq6i

Build Failed

Test summary info:

Could not find result summary

sashaNeshcheret · 2023-02-03T16:46:38Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4086137148
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4086137148
Python tests coverage:

	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
================= 19 passed, 6 skipped, 27 warnings in 17.12s ==================

subodh1810

@sashaNeshcheret so I assume Failed (ConnectException) to execute: Connection refused will only occur when the user has not configured SSH properly and there is something wrong on their end? If yes then this looks good.

...e-integrations/bases/base-java/src/main/java/io/airbyte/integrations/base/ssh/SshTunnel.java

prateekmukhedkar · 2023-09-08T22:43:30Z

Adding @rodireich because this is in scope of actionable error message, but plan to merge in next week.

Source mysql: handle ssh connection refused issue

9be5b27

sashaNeshcheret requested review from a team as code owners February 1, 2023 13:09

octavia-squidington-iv added area/connectors Connector related issues connectors/source/mysql labels Feb 1, 2023

sashaNeshcheret and others added 2 commits February 1, 2023 14:30

Source mysql: format

a43943c

Merge branch 'master' into omneshcheret/670-mysql-source-handle-ssh-c…

d060e42

…onnection-refused

jbfbell approved these changes Feb 1, 2023

View reviewed changes

sashaNeshcheret added 4 commits February 2, 2023 22:51

Source mysql: update test

fe2cd5d

Merge remote-tracking branch 'origin/omneshcheret/670-mysql-source-ha…

0816b83

…ndle-ssh-connection-refused' into omneshcheret/670-mysql-source-handle-ssh-connection-refused

Merge remote-tracking branch 'origin/master' into omneshcheret/670-my…

359a16b

…sql-source-handle-ssh-connection-refused

Source mysql: format

f056a23

Source mysql: clean code

88f38ec

subodh1810 approved these changes Feb 6, 2023

View reviewed changes

...e-integrations/bases/base-java/src/main/java/io/airbyte/integrations/base/ssh/SshTunnel.java Outdated Show resolved Hide resolved

prateekmukhedkar requested a review from rodireich September 8, 2023 22:42

fix per review comment

b3f5c54

natikgadzhi closed this Oct 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source mysql: handle ssh connection refused issue #22205

Source mysql: handle ssh connection refused issue #22205

sashaNeshcheret commented Feb 1, 2023

sashaNeshcheret commented Feb 1, 2023 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 1, 2023 •

edited

Loading

✅ Sources (31)

❌ Destinations (47)

✅ Other Modules (0)

Actionable Items

jbfbell Feb 1, 2023

sashaNeshcheret commented Feb 3, 2023 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 3, 2023 •

edited by github-actions bot

Loading

subodh1810 left a comment

prateekmukhedkar commented Sep 8, 2023

Source mysql: handle ssh connection refused issue #22205

Source mysql: handle ssh connection refused issue #22205

Conversation

sashaNeshcheret commented Feb 1, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

sashaNeshcheret commented Feb 1, 2023 • edited by github-actions bot Loading

Build Passed

sashaNeshcheret commented Feb 1, 2023 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Feb 1, 2023 • edited Loading

Affected Connector Report

✅ Sources (31)

❌ Destinations (47)

✅ Other Modules (0)

Actionable Items

jbfbell Feb 1, 2023

Choose a reason for hiding this comment

sashaNeshcheret commented Feb 3, 2023 • edited by github-actions bot Loading

Build Failed

sashaNeshcheret commented Feb 3, 2023 • edited by github-actions bot Loading

Build Passed

subodh1810 left a comment

Choose a reason for hiding this comment

prateekmukhedkar commented Sep 8, 2023

sashaNeshcheret commented Feb 1, 2023 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 1, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 1, 2023 •

edited

Loading

sashaNeshcheret commented Feb 3, 2023 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 3, 2023 •

edited by github-actions bot

Loading