🪟 🧪 Add Purchase credits CTA on trial expiry banner. #22207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letiescanciano
force-pushed
the
leeti/add-clear-cta-to-trial-expired-message
branch
from
e54b2be to
ed8dcc8
Compare
letiescanciano
requested review from
josephkmh and
timroes
and removed request for
josephkmh
timroes
reviewed
Feb 2, 2023
| @@ -38,6 +38,8 @@ const MainView: React.FC<React.PropsWithChildren<unknown>> = (props) => { | |||
| const alertToShow = showCreditsBanner ? "credits" : cloudWorkspace.trialExpiryTimestamp ? "trial" : undefined; | |||
| // exp-speedy-connection | |||
| const { isExperimentVariant } = useExperimentSpeedyConnection(); | |||
|
|
|||
| const trialUpgradeCTA = useExperiment("trial.upgrade.cta", ""); | |||
There was a problem hiding this comment.
We should not build custom experiment flags for overwriting strings. We already have a mechanism that ANY string can be experimented with using LaunchDarkly and those strings ID. See also this (internal) documentation for it: https://www.notion.so/How-to-setup-i18n-string-experiments-a661f4d933f94c3f9f7beb438d75a6eb
This PR should only add the lnk property to the trial.alertMessage and turn it into a FormattedMessage (so it can render the link), but there's no need to introduce a new experiment. Instead we should experiment with the message via the existing system.
There was a problem hiding this comment.
oh thanks for that! Now that I read it again, I remember you explain this during onboarding. I will adjust!
timroes
reviewed
Feb 2, 2023
| values={{ | ||
| remainingDays: trialRemainingDays, | ||
| cta: trialUpgradeCTA, | ||
| lnk: (ctaMessage: React.ReactNode) => ctaMessage && <Link to={CloudRoutes.Credits}>{ctaMessage}</Link>, |
There was a problem hiding this comment.
There should be no need to check for ctaMessage && here.
Right now there's no clear path for users that want to become customers during trial. We want to test different CTAs to see if: - having a CTA increase conversion to paid - different CTAs have different impact on conversion to paid More context: https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recEy67ZVQHbOFzxJ?blocks=hide
letiescanciano
force-pushed
the
leeti/add-clear-cta-to-trial-expired-message
branch
from
17988b0 to
2c63876
Compare
letiescanciano
changed the title
* master: (24 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...
timroes
approved these changes
Feb 6, 2023
letiescanciano
deleted the
leeti/add-clear-cta-to-trial-expired-message
branch
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
Right now there's no clear path for users that want to become customers during trial. We want to test different CTAs to see if: - having a CTA increase conversion to paid - different CTAs have different impact on conversion to paid More context: https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recEy67ZVQHbOFzxJ?blocks=hide
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there's no clear path for users that want to become customers during trial.
We want to test different CTAs to see if:
More context: https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recEy67ZVQHbOFzxJ?blocks=hide