🪟 🐛 Fix ResizablePanel component #22214
Merged
+37
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
approved these changes
Feb 1, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug that the resizable panel component doesn't render anything, if you first set
hideSecondPaneltotrueand then tofalse. You can currently seeing this on master by clicking in an empty workspace on a source icon in the empty connection page, which will bring you do the setup for that connector, but nothing will render, due to this issue.How
react-reflexhas apparently a problem when the second panel is first not rendered and then rendered and ends up rendering it with 0 width. The only thing to get it reworking was fully rerendering the component (by changing akeyon theReflexContainer), which worked to fix the issue, but also added a couple of new issues. So after syncing with Teal, we decided to change this to handle the hiding in CSS only, which also fixes the issue and is was less buggy.We just hide the content of the 2nd panel, so that this component doesn't render unnecessarily.