🪟 🐛 Hot-fix exception in streams table when stream does not have direct properties #22227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t properties value
edmundito
force-pushed
the
edmundito/hotfix-streams-oneof
branch
from
7b748be to
e8e54bd
Compare
josephkmh
approved these changes
Feb 1, 2023
This was referenced Feb 8, 2023
|
@edmundito Have we done the investigation for the root cause on this yet? Do we have an issue to track this? (I can't find anything linked here in the PR or the corresponding oncall issue) |
|
@edmundito @timroes I created an issue here: #22490 slack thread context: https://airbytehq-team.slack.com/archives/C02U46QK5C3/p1675778896991099?thread_ts=1675276422.305699&cid=C02U46QK5C3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Hot-fix an issue in the streams table that crashed the whole page when the properties in the stream were not of the expected shape. Still investigating the root cause and next steps, so this is a temporary fix to prevent it from impacting users.
However, the fields cannot be expanded in the table in streams where the problem occurs. This will be fixed separately.
This is occurring with the Stripe source with
plansstream in that plans is currently{ oneOf: [{ properties: ... }, 'WellKnownTypes/String' }]when the code can only support{ properties: }How
Returns an empty object so that the code can take the length correctly. Ensures that the table renders well without the expandable fields.