Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "fix: refresh actor configuration and state between sync attempts"" #22281

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Revert "Revert "fix: refresh actor configuration and state between sync attempts"" #22281

merged 3 commits into from
Feb 7, 2023

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Feb 2, 2023 •
edited
Loading

@pedroslopez pedroslopez requested a review from a team as a code owner February 2, 2023 00:26
@octavia-squidington-iii octavia-squidington-iii added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker labels Feb 2, 2023
@pedroslopez pedroslopez temporarily deployed to more-secrets February 2, 2023 00:28 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets February 2, 2023 00:28 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [78.9%] 🍏
V0_40_28_001__AddAttemptSyncConfig.java 100% 🍏
DefaultJobCreator.java 100% 🍏
DefaultJobPersistence.java 95.62% 🍏
JobTracker.java 94.7% 🍏
GenerateInputActivityImpl.java 86.04% 🍏
Attempt.java 85.65% 🍏
Job.java 84.87% 🍏
JobPersistence.java 80% 🍏
TemporalWorkerRunFactory.java 77.64% 🍏
TemporalClient.java 61.72% 🍏
ApiClientBeanFactory.java 0% ❌
ProtocolConverters.java 0% ❌
StateConverter.java 0% ❌
AttemptApiController.java 0% ❌
ApplicationBeanFactory.java 0% ❌
Total Project Coverage 24.67% ❌

@pedroslopez pedroslopez requested review from evantahler, a team and jdpgrailsdev February 2, 2023 03:46
evantahler
evantahler approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert that Revert!

@pedroslopez pedroslopez temporarily deployed to more-secrets February 7, 2023 21:31 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets February 7, 2023 21:31 — with GitHub Actions Inactive
@pedroslopez pedroslopez merged commit 44d747d into master Feb 7, 2023
@pedroslopez pedroslopez deleted the revert-22211-revert-21629-pedroslopez/attempt-sync-config branch February 7, 2023 23:42
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@pedroslopez @danidelvalle-frontiers
Revert "Revert "fix: refresh actor configuration and state between sy…
5472528 
…nc attempts"" (airbytehq#22281)

* Revert "Revert "fix: refresh actor configuration and state between sync attempts (airbytehq#21629)" (airbytehq#22211)"

This reverts commit 7978862.

* fmt
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@jdpgrailsdev jdpgrailsdev Awaiting requested review from jdpgrailsdev

Assignees
No one assigned
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroslopez @evantahler @octavia-squidington-iii