🪟 🎨🔧 Remove oauth position ff #22304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juweins
reviewed
Feb 2, 2023
letiescanciano
force-pushed
the
leti/remove-oauth-position-ff
branch
from
34e0b72 to
9597444
Compare
timroes
reviewed
Feb 6, 2023
airbyte-webapp/src/packages/cloud/views/auth/LoginPage/LoginPage.module.scss
Outdated
Show resolved
Hide resolved
timroes
reviewed
Feb 8, 2023
airbyte-webapp/src/packages/cloud/views/auth/LoginPage/LoginPage.module.scss
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Feb 8, 2023
letiescanciano
force-pushed
the
leti/remove-oauth-position-ff
branch
from
30fc7b5 to
1b31eac
Compare
letiescanciano
force-pushed
the
leti/remove-oauth-position-ff
branch
from
1b31eac to
72e08a1
Compare
We validated that having oauth signup methods on top led to better conversion rate. This PR just removes the feature flag we used and set the ouath on top of the signup form. I also took the chance to change the position in the login page for consistency
letiescanciano
force-pushed
the
leti/remove-oauth-position-ff
branch
from
72e08a1 to
30b95a8
Compare
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
* 🪟 🎨🔧 Remove oauth position ff We validated that having oauth signup methods on top led to better conversion rate. This PR just removes the feature flag we used and set the ouath on top of the signup form. I also took the chance to change the position in the login page for consistency
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We validated that having oauth signup methods on top led to better conversion rate.
This PR just removes the feature flag we used and set the ouath on top of the signup form.
I also took the chance to change the position in the login page for consistency