Source Stripe: fix schema #22312

davydov-d · 2023-02-02T14:39:31Z

What

https://github.com/airbytehq/oncall/issues/1299

How

Fix Invoices stream schema

davydov-d · 2023-02-02T14:40:34Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4075582961

davydov-d · 2023-02-02T15:46:55Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4076177475
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4076177475
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_stripe/source.py        22      0   100%
source_stripe/__init__.py       2      0   100%
source_stripe/streams.py      308     28    91%
-----------------------------------------------
TOTAL                         332     28    92%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 1.0.1.
============ 53 passed, 3 skipped, 37 warnings in 941.69s (0:15:41) ============

pedroslopez · 2023-02-06T21:12:25Z

@davydov-d I'm seeing some changes for both tiktok and stripe in this PR... is this intentional?

davydov-d · 2023-02-06T21:23:44Z

@pedroslopez thanks for flagging this. No, it's not intentional. For some reason there we changes from this PR. I've merged latest master and now there are no more non-related changes

davydov-d · 2023-02-14T07:35:24Z

/publish connector=connectors/source-stripe

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4171503861

Connector	Did it publish?	Were definitions generated?
connectors/source-stripe	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-02-15T10:21:36Z

strictness level will be changed here

alafanechere

Is it failing for all the stripe connection using the invoice stream? If yes I think the backward incompatibility is legit. Please sync with @airbytehq/cloud-support before merge to make sure the breaking change introduction is understood and if a customer outreach is required.

alafanechere · 2023-02-15T11:48:26Z

The QA checks are likely to fail, feel free to pull the changes from this PR #22886

…source-stripe-fix-schema

davydov-d · 2023-02-15T12:11:55Z

/test connector=connectors/source-stripe

davydov-d · 2023-02-15T12:14:23Z

The QA checks are likely to fail, feel free to pull the changes from this PR #22886

Thanks, pulled the changes from your PR! Regarding the release, it has already been scheduled with TCS and the outreach should have been made already

davydov-d · 2023-02-15T12:16:25Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4183760383
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4183760383
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   311     27    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      354     29    92%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 1.0.2.
============ 53 passed, 3 skipped, 37 warnings in 324.65s (0:05:24) ============

lazebnyi

Required CI builds looks good. Only one CI job is failed, because not enabled high strictness for GA. It will be implemented in #21419. We can move next to fix on-call issue.

davydov-d · 2023-02-15T14:26:18Z

/publish connector=connectors/source-stripe

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4184868607

Connector	Did it publish?	Were definitions generated?
connectors/source-stripe	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-02-15T16:15:46Z

/approve-and-merge reason="A patch for the Stripe connector to resolve #1299 oncall issue"

octavia-approvington · 2023-02-15T16:16:28Z

This is really good

davydov-d added 3 commits February 2, 2023 14:25

#1141 source tiktok: chunk advertiser IDs

d1ad22b

#1141 source tiktok: upd changelog

dd4659c

#1299 source stripe: fix Invoices schema

dc97c58

davydov-d changed the title ~~Source stripe fix schema~~ Source Stripe: fix schema Feb 2, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe connectors/source/tiktok-marketing labels Feb 2, 2023

#1299 source stripe: upd changelog

95265e1

davydov-d requested review from lazebnyi, pedroslopez and roman-yermilov-gl February 2, 2023 14:41

roman-yermilov-gl approved these changes Feb 2, 2023

View reviewed changes

#1299 source stripe: upd acceptance test config

0bff217

lazebnyi approved these changes Feb 2, 2023

View reviewed changes

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

5be6831

source-stripe: no http url in openapi_spec.json

85f521f

alafanechere and others added 6 commits February 14, 2023 09:06

Merge branch 'master' into augustin/source-stripe/no-http-url

06d9c8f

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

c6311a7

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

bb3bd1d

#1299 source stripe: fix SAT config

9c126c4

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

3c9feaf

#1299 source stripe: add allowedHosts

fc2cdce

davydov-d temporarily deployed to more-secrets February 15, 2023 10:08 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

9de61ce

davydov-d temporarily deployed to more-secrets February 15, 2023 10:56 — with GitHub Actions Inactive

davydov-d requested review from a team February 15, 2023 11:43

alafanechere approved these changes Feb 15, 2023

View reviewed changes

Merge branch 'augustin/source-stripe/no-http-url' into ddavydov/#1299-…

87f7198

…source-stripe-fix-schema

davydov-d temporarily deployed to more-secrets February 15, 2023 12:13 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

36b4048

davydov-d temporarily deployed to more-secrets February 15, 2023 13:06 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 15, 2023

View reviewed changes

auto-bump connector version

f3ed1f0

airbyteio temporarily deployed to more-secrets February 15, 2023 14:51 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#1299-source-stripe-fix-schema

fd19c4b

davydov-d temporarily deployed to more-secrets February 15, 2023 15:40 — with GitHub Actions Inactive

octavia-approvington approved these changes Feb 15, 2023

View reviewed changes

octavia-approvington merged commit 0ee920e into master Feb 15, 2023

octavia-approvington deleted the ddavydov/#1299-source-stripe-fix-schema branch February 15, 2023 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Stripe: fix schema #22312

Source Stripe: fix schema #22312

davydov-d commented Feb 2, 2023

davydov-d commented Feb 2, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 2, 2023 •

edited by github-actions bot

Loading

pedroslopez commented Feb 6, 2023

davydov-d commented Feb 6, 2023

davydov-d commented Feb 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023

alafanechere left a comment

alafanechere commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading

lazebnyi left a comment

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023

octavia-approvington commented Feb 15, 2023

Source Stripe: fix schema #22312

Source Stripe: fix schema #22312

Conversation

davydov-d commented Feb 2, 2023

What

How

davydov-d commented Feb 2, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

pedroslopez commented Feb 6, 2023

davydov-d commented Feb 6, 2023

davydov-d commented Feb 14, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 15, 2023

alafanechere left a comment

Choose a reason for hiding this comment

alafanechere commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

davydov-d commented Feb 15, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 15, 2023

octavia-approvington commented Feb 15, 2023

davydov-d commented Feb 2, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 2, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading