Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source google search console: turn on default HttpAvailabilityStrategy #22334

Merged
merged 6 commits into from
Feb 7, 2023
+49 −53
Merged

Source google search console: turn on default HttpAvailabilityStrategy #22334

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08fc717
use default AvailabilityStrategy
grubberr Feb 2, 2023
d2aa8ca
google-search-console.md updated
grubberr Feb 2, 2023
9bbde24
Merge branch 'master' into grubberr/22253-source-google-search-console
grubberr Feb 6, 2023
6bdc562
Merge branch 'master' into grubberr/22253-source-google-search-console
grubberr Feb 6, 2023
afb385d
expected_records.jsonl updated
grubberr Feb 6, 2023
1a29058
auto-bump connector version
octavia-squidington-iii Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-search-console/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.19
LABEL io.airbyte.version=0.1.20
LABEL io.airbyte.name=airbyte/source-google-search-console
5 changes: 0 additions & 5 deletions ...egrations/connectors/source-google-search-console/source_google_search_console/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import pendulum
import requests
from airbyte_cdk.models import SyncMode
from airbyte_cdk.sources.streams.availability_strategy import AvailabilityStrategy
from airbyte_cdk.sources.streams.http import HttpStream
from airbyte_cdk.sources.streams.http.auth import HttpAuthenticator

Expand All @@ -34,10 +33,6 @@ def __init__(
self._start_date = start_date
self._end_date = end_date

@property
def availability_strategy(self) -> Optional["AvailabilityStrategy"]:
return None

@staticmethod
def sanitize_urls_list(site_urls: list) -> List[str]:
return list(map(quote_plus, site_urls))
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/google-search-console.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ This connector attempts to back off gracefully when it hits Reports API's rate l

| Version | Date | Pull Request | Subject |
|:---------| :--------- |:--------------------------------------------------------------------------------------------------------------| :---------------------------------------------------------- |
| `0.1.19` | 2023-01-27 | [22007](https://github.com/airbytehq/airbyte/pull/22007) | Set `AvailabilityStrategy` for streams explicitly to `None` |
| `0.1.20` | 2023-02-02 | [22334](https://github.com/airbytehq/airbyte/pull/22334) | Turn on default HttpAvailabilityStrategy |
| `0.1.19` | 2023-01-27 | [22007](https://github.com/airbytehq/airbyte/pull/22007) | Set `AvailabilityStrategy` for streams explicitly to `None` |
| `0.1.18` | 2022-10-27 | [18568](https://github.com/airbytehq/airbyte/pull/18568) | Improved config validation: custom_reports.dimension |
| `0.1.17` | 2022-10-08 | [17751](https://github.com/airbytehq/airbyte/pull/17751) | Improved config validation: start_date, end_date, site_urls |
| `0.1.16` | 2022-09-28 | [17304](https://github.com/airbytehq/airbyte/pull/17304) | Migrate to per-stream state. |
Expand Down