Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: Migrate products_report stream to API v3 #22355

Merged
merged 12 commits into from
Mar 31, 2023
Merged

Source Amazon Ads: Migrate products_report stream to API v3 #22355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fad169a
Migrate products_report stream to API v3
lazebnyi Feb 3, 2023
d7be2b2
Updated PR number
lazebnyi Feb 3, 2023
92efb01
Merge branch 'master' into lazebnyi/21252-source-amazon-ads-migrate-r…
lazebnyi Mar 30, 2023
5b36695
Merge branch 'master' into lazebnyi/21252-source-amazon-ads-migrate-r…
grubberr Mar 30, 2023
4e259de
fix
Mar 30, 2023
bdf06ed
fix tests
grubberr Mar 30, 2023
efd126b
Fixed unttests
lazebnyi Mar 30, 2023
9de2de6
Merge master to branch
lazebnyi Mar 30, 2023
0ed84e6
Fix Metric response
lazebnyi Mar 30, 2023
8ddfdf2
Fix typo
lazebnyi Mar 30, 2023
46c7ec4
Fix integrations test tdue migration
lazebnyi Mar 30, 2023
263be8b
auto-bump connector version
octavia-squidington-iii Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
- name: Amazon Ads
sourceDefinitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
dockerRepository: airbyte/source-amazon-ads
dockerImageTag: 1.0.1
dockerImageTag: 1.0.2
documentationUrl: https://docs.airbyte.com/integrations/sources/amazon-ads
icon: amazonads.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-amazon-ads:1.0.1"
- dockerImage: "airbyte/source-amazon-ads:1.0.2"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/amazon-ads"
connectionSpecification:
Expand Down
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-amazon-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]


LABEL io.airbyte.version=1.0.1

LABEL io.airbyte.version=1.0.2
LABEL io.airbyte.name=airbyte/source-amazon-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integrat
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
First install test dependencies into your virtual environment:
```
pip install .[tests]
pip install .'[tests]'
```
### Unit Tests
To run unit tests locally, from the connector directory run:
Expand Down
13 changes: 1 addition & 12 deletions airbyte-integrations/connectors/source-amazon-ads/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,9 @@ acceptance_tests:
tests:
- config_path: secrets/config.json
configured_catalog_path: integration_tests/configured_catalog.json
- config_path: secrets/config_report.json
configured_catalog_path: integration_tests/configured_catalog_report.json
timeout_seconds: 3600
incremental:
tests:
- config_path: secrets/config_report.json
configured_catalog_path: integration_tests/configured_catalog_report.json
cursor_paths:
sponsored_products_report_stream:
- "1861552880916640"
- reportDate
future_state:
future_state_path: integration_tests/abnormal_state.json
timeout_seconds: 2400
bypass_reason: "can't populate stream because it requires real ad campaign"
spec:
tests:
- spec_path: integration_tests/spec.json
Expand Down
Loading