Source LinkedIn Ads: turn on default HttpAvailabilityStrategy #22361

grubberr · 2023-02-03T10:45:49Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Issue: #22259 #21783
Turn on default HttpAvailabilityStrategy - it works ok for this connector

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-03T10:51:15Z

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/4083450967
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/4083450967
Python tests coverage:

Name                               Stmts   Miss  Cover
------------------------------------------------------
source_linkedin_ads/analytics.py      45      0   100%
source_linkedin_ads/__init__.py        2      0   100%
source_linkedin_ads/utils.py          91      5    95%
source_linkedin_ads/source.py        195     27    86%
------------------------------------------------------
TOTAL                                333     32    90%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 345.99s (0:05:45) ===================

erohmensing

Hm something went weird in this connector - the changelog entries don't line up. I released 1.13 here: #22013

grubberr · 2023-02-06T17:22:42Z

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/4106215899
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/4106215899
Python tests coverage:

Name                               Stmts   Miss  Cover
------------------------------------------------------
source_linkedin_ads/analytics.py      45      0   100%
source_linkedin_ads/__init__.py        2      0   100%
source_linkedin_ads/utils.py          91      5    95%
source_linkedin_ads/source.py        195     27    86%
------------------------------------------------------
TOTAL                                333     32    90%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 351.36s (0:05:51) ===================

grubberr · 2023-02-06T18:19:54Z

/publish connector=connectors/source-linkedin-ads

grubberr · 2023-02-06T18:40:52Z

/publish connector=connectors/source-linkedin-ads

🕑 Publishing the following connectors:
connectors/source-linkedin-ads
https://github.com/airbytehq/airbyte/actions/runs/4106843388

Connector	Did it publish?	Were definitions generated?
connectors/source-linkedin-ads	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-02-06T19:15:42Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.55%	❌

bump 0.1.14

d4f4ef5

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added area/connectors Connector related issues connectors/source/linkedin-ads labels Feb 3, 2023

grubberr added 2 commits February 3, 2023 10:46

remove empty availability_strategy

37659e8

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

linkedin-ads.md updated

f25216b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 3, 2023

grubberr self-assigned this Feb 3, 2023

grubberr requested review from davydov-d and lazebnyi February 3, 2023 10:52

davydov-d approved these changes Feb 3, 2023

View reviewed changes

lazebnyi requested a review from erohmensing February 3, 2023 12:15

lazebnyi changed the title ~~Source source-linkedin-ads: turn on default HttpAvailabilityStrategy~~ Source LinkedIn Ads: turn on default HttpAvailabilityStrategy Feb 3, 2023

lazebnyi approved these changes Feb 3, 2023

View reviewed changes

erohmensing approved these changes Feb 3, 2023

View reviewed changes

Merge branch 'master' into grubberr/22259-source-linkedin-ads

c625495

auto-bump connector version

c6d6a42

airbyteio temporarily deployed to more-secrets February 6, 2023 19:07 — with GitHub Actions Inactive

grubberr merged commit 22838c2 into master Feb 6, 2023

grubberr deleted the grubberr/22259-source-linkedin-ads branch February 6, 2023 20:13

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source LinkedIn Ads: turn on default HttpAvailabilityStrategy #22361

Source LinkedIn Ads: turn on default HttpAvailabilityStrategy #22361

grubberr commented Feb 3, 2023 •

edited

Loading

grubberr commented Feb 3, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 6, 2023

Source LinkedIn Ads: turn on default HttpAvailabilityStrategy #22361

Source LinkedIn Ads: turn on default HttpAvailabilityStrategy #22361

Conversation

grubberr commented Feb 3, 2023 • edited Loading

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Feb 3, 2023 • edited by github-actions bot Loading

Build Passed

erohmensing left a comment

Choose a reason for hiding this comment

grubberr commented Feb 6, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Feb 6, 2023

grubberr commented Feb 6, 2023 • edited by github-actions bot Loading

github-actions bot commented Feb 6, 2023

Airbyte Code Coverage

grubberr commented Feb 3, 2023 •

edited

Loading

grubberr commented Feb 3, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 6, 2023 •

edited by github-actions bot

Loading