Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of functions for pod sweeper #22374

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix naming of functions for pod sweeper #22374

merged 2 commits into from
Feb 7, 2023

Conversation

terencecho
Copy link
Contributor

What

pod sweeper was changed to sweeping job pods instead of worker pods through #21829, but the method names were not changed.

🚨 User Impact 🚨

Change is only for code readability, no impact on behavior.

@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform kubernetes labels Feb 3, 2023
@terencecho terencecho requested a review from davinchia February 3, 2023 19:19
@terencecho terencecho temporarily deployed to more-secrets February 3, 2023 19:20 — with GitHub Actions Inactive
@terencecho terencecho temporarily deployed to more-secrets February 3, 2023 19:20 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52%

@terencecho terencecho requested a review from c-p-b February 6, 2023 19:21
@c-p-b
Copy link
Contributor

c-p-b commented Feb 7, 2023

Thanks terence!

@terencecho terencecho enabled auto-merge (squash) February 7, 2023 17:18
@terencecho terencecho merged commit cf157bc into master Feb 7, 2023
@terencecho terencecho deleted the tcho/fix-naming branch February 7, 2023 17:19
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
* Fix naming of functions for pod sweeper

* Fix naming of functions for pod sweeper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants