🪟🔧 Connector builder: Do not rely on local cdk anymore #22391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2023 15:17
octavia-squidington-iii
added
the
area/documentation
lmossman
reviewed
Feb 6, 2023
Comment on lines
+4
to
+5
| # Make sure this is aligned with the CDK version of the connector builder server | ||
| DEFAULT_CDK_VERSION="0.25.0" |
There was a problem hiding this comment.
Just confirming, is the plan to address keeping these aligned automatically in a follow-up PR, since in the description you said this PR does not fully close that issue?
Do you have an idea of how to solve that?
lmossman
approved these changes
Feb 6, 2023
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
* do not rely on local cdk anymore * cache versioned schemas * fix used version * review comments
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to #21830
Downloads the CDK in the specified version as part of the frontend build to build typescript types instead of relying on CDK files in a folder as part of the same repo.
This is not fixing the linked issue as it's not ensuring connector builder server and webapp use the same version of the CDK, it's done to unblock the repo split in the short term.
How
Do a curl request to fetch the tar ball of the cdk, then extract the declarative manifest schema from it. Also add a way to overwrite the used version and location of the manifest schema via environment variables to allow local development.