Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector acceptance test: Fix oneof check #22395

Merged
merged 9 commits into from
Feb 9, 2023

Conversation

flash1293
Copy link
Contributor

Noticed a small issue in the connector acceptance tests - if oneOfs are nested, the test fails because it's trying to join a list made out of strings and ints. This PR makes sure this works and also adjusts the types.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

❌ Sources (63)

Connector Version Changelog Publish
source-airtable 2.0.3
source-amazon-ads 1.0.0
source-amazon-seller-partner 0.2.31
source-amazon-sqs 0.1.0
source-amplitude 0.1.21
source-appsflyer 0.1.0
source-asana 0.1.5
source-azure-table 0.1.3
source-braintree 0.1.3
source-cart 0.2.0
source-chargebee 0.1.16
source-commercetools 0.1.0
source-confluence 0.1.1
source-datadog 0.1.0
source-delighted 0.2.0
source-drift 0.2.5
source-facebook-marketing 0.2.84
source-freshcaller 0.1.0
source-freshsales 0.1.2
source-freshservice 0.1.1
source-github 0.4.1
source-gitlab 1.0.2
source-google-ads 0.2.9
source-google-search-console 0.1.20
source-greenhouse 0.3.0
source-harvest 0.1.15
source-instagram 1.0.1
source-iterable 0.1.23
source-klaviyo 0.1.12
source-lemlist 0.1.1
source-lever-hiring 0.1.3
source-linnworks 0.1.5
source-mailchimp 0.3.4
source-mailgun 0.1.0
source-monday 0.2.2
source-notion 1.0.1
source-okta 0.1.14
source-onesignal 0.1.2
source-openweather 0.1.6
source-outreach 0.1.2
source-pardot 0.1.1
source-paystack 0.1.1
source-pinterest 0.2.2
source-pipedrive 0.1.13
source-plaid 0.3.2
source-posthog 0.1.8
source-prestashop 0.3.0
source-quickbooks-singer 0.1.5
source-recharge 0.2.6
(diff seed version)
source-retently 0.1.3
source-salesforce 2.0.1
source-salesloft 0.1.3
source-sendgrid 0.3.1
source-sentry 0.1.11
source-strava 0.1.2
source-surveymonkey 0.1.14
source-tplcentral 0.1.1
source-twilio 0.1.15
source-weatherstack 0.1.0
source-youtube-analytics 0.1.3
source-zendesk-sunshine 0.1.1
source-zendesk-talk 0.1.6
source-zenloop 0.1.4
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@flash1293 flash1293 marked this pull request as ready for review February 6, 2023 13:27
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@flash1293
Copy link
Contributor Author

flash1293 commented Feb 9, 2023

/test connector=bases/connector-acceptance-test

🕑 bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4136373425
✅ bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4136373425
No Python unittests run

Build Passed

Test summary info:

All Passed

@flash1293
Copy link
Contributor Author

flash1293 commented Feb 9, 2023

/publish connector=bases/connector-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/connector-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/4136707123


Connector Did it publish? Were definitions generated?
bases/connector-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293 flash1293 merged commit d82e01a into master Feb 9, 2023
@flash1293 flash1293 deleted the flash1293/nested-one-of-fix branch February 9, 2023 19:37
marcosmarxm pushed a commit that referenced this pull request Feb 9, 2023
* fix oneof check

* adjust changelog

* adjust changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants