🪟🐛 Connector form: Fix squeezed status icon #22396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2023 16:49
This reverts commit 09d730a.
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
* fix visual bug * Revert "fix visual bug" This reverts commit 09d730a. * prevent status icon squeezing
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the space is tight, the status icon in the connector form can be shown in a squeezed way. This PR makes sure it's always shown properly by preventing it to shrink in a flex context:
I know this is changing a styled component without converting it and I started this work but then realized there's a bit more work to that because there are so many special cases and doing it right would require quite a bit of refactoring. I will create a separate issue for that and tackle it as a filler once I find the time