Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🧪 [Experiment] Simplify signup left side #22402

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

letiescanciano
Copy link
Contributor

@letiescanciano letiescanciano commented Feb 6, 2023

We want to experiment if simplifying the left side on the sign up page and dividing the signup methods, increase conversion of corporate emails on the page. How?

  • Making Oauth the default method
  • Email/password method is still available but user will see an error for personal emails. They can still sign up though.

Airtable details:
https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recnFzE4HBB8RP1uY?blocks=hide
Demo: https://www.loom.com/share/9b706682d89845b1bf2455a1f3e1520d

@octavia-squidington-iii octavia-squidington-iii added the area/frontend Related to the Airbyte webapp label Feb 6, 2023
@letiescanciano letiescanciano requested review from a team as code owners February 6, 2023 17:46
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker CDK Connector Development Kit connectors/source/sentry connectors/source/amazon-ads connectors/source/freshdesk connectors/source/klaviyo labels Feb 6, 2023
@letiescanciano letiescanciano force-pushed the leti/improve-signup-left-side branch from 4f4fbfe to 0c91af8 Compare February 6, 2023 17:47
@octavia-squidington-iii octavia-squidington-iii removed area/connectors Connector related issues area/worker Related to worker area/documentation Improvements or additions to documentation CDK Connector Development Kit area/platform issues related to the platform labels Feb 6, 2023
@letiescanciano letiescanciano force-pushed the leti/improve-signup-left-side branch from 0c91af8 to e51296e Compare February 6, 2023 17:49
@@ -0,0 +1,9 @@
<svg width="18" height="20" viewBox="0 0 18 20" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Is this icon used somewhere? I can't find any reference to this in your PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover sorry!

Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I've left some code cleanup and wording suggestions to discuss.

airbyte-webapp/src/packages/cloud/locales/en.json Outdated Show resolved Hide resolved
airbyte-webapp/src/packages/cloud/locales/en.json Outdated Show resolved Hide resolved
);
};
export const SimpleLeftSide: React.FC = () => {
const [showOauth, setShowOauth] = useState(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Once we clean this up, it would be nicer to manage this via an URL route instead. Currently when switching between those the back button of your browser won't go back, since we only manage this state in JS, which already got me multiple times. I think for the final implementation this shoudl be separate routes, so your back button works as expected when switching between them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, if it's the same action (signup) but just two different flows, in which cases do you think it make more sense to have two routes?
I didn't think about the back button to be honest, as you can just use the elements in the page to navigate, but I'm talking from my ignorance in this matter!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main decision driver would be: "Does the user think those are different 'pages' and she'd expect the back button to go back to the previous one?" If so, I usually would try to make it different routes in most cases, since it's easier than manually mess with the history state, to achieve the same without adding different routes.

Just for technical completion: The way you can hack around that without using routes is doing something (pseudo code, I'm not sure if the navigate is actually the right method by heart to push to the history without actually causing the browser to navigate in react router v6):

const location = useLocation();
const navigate = useNavigate();
const [showOauth, setShowOAuthState] = useState(location.state?.data.showOAuth);

const setShowOAuth = () => {
  navigate("/signup", { state: { showOauth: true }});
  setShowOAuthState(true);
};

@letiescanciano letiescanciano force-pushed the leti/remove-oauth-position-ff branch 2 times, most recently from 1b31eac to 72e08a1 Compare February 8, 2023 13:48
@letiescanciano letiescanciano force-pushed the leti/remove-oauth-position-ff branch from 72e08a1 to 30b95a8 Compare February 8, 2023 13:54
@letiescanciano letiescanciano force-pushed the leti/improve-signup-left-side branch from e51296e to ca1e6df Compare February 8, 2023 14:07
Base automatically changed from leti/remove-oauth-position-ff to master February 8, 2023 14:23
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally seems to work (despite the "navigating back" issue, which we can fix once we end the experiment).

);
};
export const SimpleLeftSide: React.FC = () => {
const [showOauth, setShowOauth] = useState(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main decision driver would be: "Does the user think those are different 'pages' and she'd expect the back button to go back to the previous one?" If so, I usually would try to make it different routes in most cases, since it's easier than manually mess with the history state, to achieve the same without adding different routes.

Just for technical completion: The way you can hack around that without using routes is doing something (pseudo code, I'm not sure if the navigate is actually the right method by heart to push to the history without actually causing the browser to navigate in react router v6):

const location = useLocation();
const navigate = useNavigate();
const [showOauth, setShowOAuthState] = useState(location.state?.data.showOAuth);

const setShowOAuth = () => {
  navigate("/signup", { state: { showOauth: true }});
  setShowOAuthState(true);
};

We want to experiment if simplifying the left side on the sign up page
and dividing the signup methods, increase conversion of corporate emails
on the page. How?
- Making Oauth the default method
- Email/password method is still available but user will see an error
  for personal emails. They can still sign up though.

Airtable details:
https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recnFzE4HBB8RP1uY?blocks=hide
Demo: https://www.loom.com/share/9b706682d89845b1bf2455a1f3e1520d
@letiescanciano letiescanciano force-pushed the leti/improve-signup-left-side branch from ca1e6df to 046fa95 Compare February 8, 2023 17:11
@letiescanciano letiescanciano merged commit 17c77fc into master Feb 9, 2023
@letiescanciano letiescanciano deleted the leti/improve-signup-left-side branch February 9, 2023 07:43
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
* 🪟 🧪 [Experiment] Simplify signup left side

We want to experiment if simplifying the left side on the sign up page
and dividing the signup methods, increase conversion of corporate emails
on the page. How?
- Making Oauth the default method
- Email/password method is still available but user will see an error
  for personal emails. They can still sign up though.

Airtable details:
https://airtable.com/appIuY0uKPVnk8TWT/tbl2SxXnUwf6fVCWS/viw9frYvld7ks7aNo/recnFzE4HBB8RP1uY?blocks=hide
Demo: https://www.loom.com/share/9b706682d89845b1bf2455a1f3e1520d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/growth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants