Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Improve Output when overwriting experiments #22409

Merged
merged 4 commits into from
Feb 7, 2023
Merged

🪟 🔧 Improve Output when overwriting experiments #22409

merged 4 commits into from
Feb 7, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Feb 6, 2023

What

Improve console output when experiments are overwritten:

  • Makes sure it's only output once (in the main thread, not all the worker threads spawned by vite-plugin-checker).
  • Styles the output a bit nicer:

screenshot-20230206-145137

@octavia-squidington-iii octavia-squidington-iii added the area/frontend Related to the Airbyte webapp label Feb 6, 2023
@timroes timroes mentioned this pull request Feb 6, 2023
Merged
@timroes timroes requested a review from lmossman February 6, 2023 13:53
@timroes timroes changed the title Improve Output when overwriting experiments 🪟 🔧 Improve Output when overwriting experiments Feb 6, 2023
@timroes timroes requested a review from josephkmh February 6, 2023 18:38
lmossman
lmossman approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, output looks clean from local testing and works as expected!

@timroes timroes merged commit da924a4 into master Feb 7, 2023
@timroes timroes deleted the tim/cli-improvements branch February 7, 2023 10:38
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@timroes @danidelvalle-frontiers
🪟 🔧 Improve Output when overwriting experiments (airbytehq#22409)
a64567f 
* Improve Output when overwriting experiments

* FIx file name in log

* Update pnpm lockfile
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman lmossman approved these changes

@josephkmh josephkmh Awaiting requested review from josephkmh

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @lmossman @octavia-squidington-iii