Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pod-sweeper to allow multi-ns deploy #22415

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Update pod-sweeper to allow multi-ns deploy #22415

merged 2 commits into from
Feb 7, 2023

Conversation

xpuska513
Copy link
Contributor

What

  • Update pod-sweeper chart to allow namespace value override

@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform kubernetes labels Feb 6, 2023
@xpuska513 xpuska513 temporarily deployed to more-secrets February 6, 2023 15:22 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets February 6, 2023 15:23 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.53% ❌

Mykyta-Serbynevskyi
Mykyta-Serbynevskyi approved these changes Feb 7, 2023
View reviewed changes
charts/airbyte-pod-sweeper/values.yaml Outdated

## namespace [string] namespace to deploy pod-sweeper at
namespace: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

@xpuska513 xpuska513 temporarily deployed to more-secrets February 7, 2023 13:12 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets February 7, 2023 13:12 — with GitHub Actions Inactive
@xpuska513 xpuska513 merged commit 697b747 into master Feb 7, 2023
@xpuska513 xpuska513 deleted the kskobylko/update-pod-sweeper-multi-ns branch February 7, 2023 13:54
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@xpuska513 @danidelvalle-frontiers
Update pod-sweeper to allow multi-ns deploy (airbytehq#22415)
5f852ba 
* Update pod-sweeper to allow multi-ns deploy

* nit newline
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mykyta-Serbynevskyi Mykyta-Serbynevskyi Mykyta-Serbynevskyi approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xpuska513 @Mykyta-Serbynevskyi @octavia-squidington-iii