pass launchdarkly api environment variable to orchestrator #22428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/platform
mfsiega-airbyte
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
davinchia
reviewed
Feb 6, 2023
Comment on lines
105
to
107
| environmentVariables.put(EnvConfigs.SOCAT_KUBE_CPU_LIMIT, configs.getSocatSidecarKubeCpuLimit()); | ||
| environmentVariables.put(EnvConfigs.SOCAT_KUBE_CPU_REQUEST, configs.getSocatSidecarKubeCpuRequest()); | ||
| environmentVariables.put(EnvConfigs.LAUNCHDARKLY_KEY, configs.getLaunchDarklyKey()); |
colesnodgrass
approved these changes
Feb 6, 2023
mfsiega-airbyte
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
mfsiega-airbyte
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
mfsiega-airbyte
deleted the
msiega/pass-launchdarkly-key-to-orchestrator
branch
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…#22428) * pass launchdarkly api environment variable to orchestrator * Put env vars in alphabetical order
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make it possible to configure a launchdarkly api key for featureflag clients instantiated from the orchestrator.
How
Pass launchdarkly api key environment variable through to the orchestrator.